Skip to content

Commit 633e4b4

Browse files
author
taylorcyang
committed
bugfix: fix CI errors
1 parent 3d073e6 commit 633e4b4

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

.github/workflows/coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
backends: [ V8, JavaScriptCore, QuickJs, Lua ]
2222
steps:
2323
- uses: actions/checkout@v4.1.7
24-
- uses: actions/cache@v4.0.2
24+
- uses: actions/cache@v4
2525
with:
2626
key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
2727
path: |

.github/workflows/unit_tests.yml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
# - Release
2626
steps:
2727
- uses: actions/checkout@v4.1.7
28-
- uses: actions/cache@v4.0.2
28+
- uses: actions/cache@v4
2929
with:
3030
key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
3131
path: |
@@ -62,7 +62,7 @@ jobs:
6262
- Release
6363
steps:
6464
- uses: actions/checkout@v4.1.7
65-
- uses: actions/cache@v4.0.2
65+
- uses: actions/cache@v4
6666
with:
6767
key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
6868
path: |
@@ -113,7 +113,7 @@ jobs:
113113
- Release
114114
steps:
115115
- uses: actions/checkout@v4.1.7
116-
- uses: actions/cache@v4.0.2
116+
- uses: actions/cache@v4
117117
with:
118118
key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
119119
path: |
@@ -148,7 +148,7 @@ jobs:
148148
job_split: [ 0/8, 1/8, 2/8, 3/8, 4/8, 5/8, 6/8, 7/8 ]
149149
steps:
150150
- uses: actions/checkout@v4.1.7
151-
- uses: actions/cache@v4.0.2
151+
- uses: actions/cache@v4
152152
with:
153153
key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
154154
path: |
@@ -177,7 +177,7 @@ jobs:
177177
- Release
178178
steps:
179179
- uses: actions/checkout@v4.1.7
180-
- uses: actions/cache@v4.0.2
180+
- uses: actions/cache@v4
181181
with:
182182
key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
183183
path: |
@@ -206,7 +206,7 @@ jobs:
206206
strategy:
207207
fail-fast: false
208208
matrix:
209-
node-version: [ 14.x, 15.x, 16.x, 18.x ] # 19.x
209+
node-version: [ 18.x, 20.x, 22.x, 24.x ]
210210
steps:
211211
- uses: actions/checkout@v4.1.7
212212
- name: Use Node.js ${{ matrix.node-version }}
@@ -233,7 +233,7 @@ jobs:
233233
emscripten-version: [ '4.0.0', '3.1.33' ]
234234
steps:
235235
- uses: actions/checkout@v4.1.7
236-
- uses: actions/cache@v4.0.2
236+
- uses: actions/cache@v4
237237
with:
238238
key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
239239
path: |
@@ -264,5 +264,4 @@ jobs:
264264
run: |
265265
cd build
266266
# exclude failed tests
267-
# --no-experimental-fetch config from https://github.com/emscripten-core/emscripten/issues/16915
268-
node --no-experimental-fetch UnitTests.js '--gtest_filter=-ThreadPool.*:EngineScopeTest.ExitEngine:EngineScopeTest.TwoThreads:EngineScopeTest.ThreadLocal:MessageQueue.Interrupt:MessageQueue.Shutdown:MessageQueue.ShutdownNow:MessageQueue.FullAndPostInsideLoopQueue:ReferenceTest.WeakGc:ReferenceTest.WeakGc:ReferenceTest.GlobalNotClear:ReferenceTest.GlobalOnEngineDestroy:ReferenceTest.WeakOnEngineDestroy:ReferenceTest.WeakNotClrear:ManagedObjectTest.EngineDispose:ManagedObjectTest.FunctionCallback:PressureTest.All:EngineTest.JsPromiseTest:EngineTest.JsPromiseTest2:ShowCaseTest.SetTimeout'
267+
node UnitTests.js '--gtest_filter=-ThreadPool.*:EngineScopeTest.ExitEngine:EngineScopeTest.TwoThreads:EngineScopeTest.ThreadLocal:MessageQueue.Interrupt:MessageQueue.Shutdown:MessageQueue.ShutdownNow:MessageQueue.FullAndPostInsideLoopQueue:ReferenceTest.WeakGc:ReferenceTest.WeakGc:ReferenceTest.GlobalNotClear:ReferenceTest.GlobalOnEngineDestroy:ReferenceTest.WeakOnEngineDestroy:ReferenceTest.WeakNotClrear:ManagedObjectTest.EngineDispose:ManagedObjectTest.FunctionCallback:PressureTest.All:EngineTest.JsPromiseTest:EngineTest.JsPromiseTest2:ShowCaseTest.SetTimeout'

src/utils/MessageQueue.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include <functional>
2626
#include <limits>
2727
#include <mutex>
28+
#include <stdexcept>
2829
#include <vector>
2930
#include "../foundation.h"
3031
#include "MemoryPool.hpp"

test/src/ThreadPoolTest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ void runThreadpoolBenchmark() {
8282
using std::chrono::milliseconds;
8383
using std::chrono::nanoseconds;
8484
using std::chrono::steady_clock;
85-
using std::chrono_literals::operator""ms;
85+
using std::literals::chrono_literals::operator""ms;
8686

8787
constexpr auto kEnableMultiThreadTest = false;
8888
constexpr auto kRunTimeMs = 200ms;

test/src/ValueTest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ void testNumber(T value) {
557557
EXPECT_EQ(num.toInt64(), static_cast<int64_t>(value));
558558
#endif
559559
EXPECT_FLOAT_EQ(num.toFloat(), static_cast<float>(value));
560-
EXPECT_FLOAT_EQ(num.toDouble(), static_cast<double>(value));
560+
EXPECT_DOUBLE_EQ(num.toDouble(), static_cast<double>(value));
561561
}
562562

563563
TEST_F(ValueTest, Number) {

0 commit comments

Comments
 (0)