ci use apt qemu#5998
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI workflow configuration files to use the apt-based installation of qemu and standardizes various job steps for multiple architectures. Key changes include:
- Renaming job identifiers (e.g. from "gcc-ppc" to "ppc", "gcc-mips64el" to "mips64el", etc.) and updating build/test step commands to use multi-line script blocks.
- Installing qemu-user-static in addition to the appropriate cross-compilers across workflows.
- Updating test command executables from their dynamic versions to the “-static” versions.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/linux-ppc64.yml | Renamed jobs and updated build/test steps with a multiline script. |
| .github/workflows/linux-mips64.yml | Renamed job, added qemu-user-static installation, and updated commands. |
| .github/workflows/linux-mips.yml | Renamed jobs, installed qemu-user-static, and updated test commands. |
| .github/workflows/linux-arm.yml | Renamed jobs and updated toolchain installation and test steps. |
| .github/workflows/linux-aarch64.yml | Updated job names and added several test steps with CPU-specific options. |
Comments suppressed due to low confidence (2)
.github/workflows/linux-ppc64.yml:32
- [nitpick] Consider using a consistent naming convention for job identifiers across CI workflows; for example, using the 'gcc-ppc' prefix might better indicate the compiler context.
ppc:
.github/workflows/linux-aarch64.yml:32
- [nitpick] Standardize the job names for aarch64 workflows (e.g., choosing between 'aarch64-native' and 'aarch64') to maintain clarity and consistency across architectures.
aarch64-native:
|
The binary size change of libncnn.so (bytes)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.