pnnx ncnn legalize global pooling layout#6795
Conversation
|
|
|
Supplementary notes for this PR: This PR changes pnnx ncnn conversion around global pooling layout, without changing ncnn runtime Design split:
Expected generated graph examples:
Tests added/updated:
Focused validation run locally: cd tools/pnnx/build
make -j16 pnnx
ctest --output-on-failure -R "AdaptiveAvgPool|AdaptiveMaxPool|Linear|Conv2d|global_pooling|binaryop_broadcast_cleanup|numpy_binaryop_broadcast|batch_layout|solve_batch_index"Result: 21/21 passed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05fbcc10ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ee2f629e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb079900f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
link #6777 |
No description provided.