Skip to content

Commit 9af6776

Browse files
fix(collapse): 修复深色模式下面板左侧图标颜色错误 (#4185)
* fix(collapse): 修复深色模式下图标颜色 * fix(collapse): 修复深色模式下图标颜色 * fix(CollapsePanel): add --td-collapse-left-icon-color * feat(CollapsePanel): add --td-collapse-disabled-color --------- Co-authored-by: anlyyao <anly_yaw@163.com>
1 parent e773aa0 commit 9af6776

6 files changed

Lines changed: 29 additions & 34 deletions

File tree

packages/components/collapse-panel/collapse-panel.less

Lines changed: 17 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
@import '../common/style/base.less';
22

3+
@collapse-disabled-color: var(--td-collapse-disabled-color, @text-color-disabled);
34
@collapse-header-text-color: var(--td-collapse-header-text-color, @text-color-primary);
45
@collapse-content-text-color: var(--td-collapse-content-text-color, @text-color-primary);
5-
@collapse-header-text-disabled-color: var(--td-collapse-header-text-disabled-color, @text-color-disabled);
6+
@collapse-header-text-disabled-color: var(--td-collapse-header-text-disabled-color, @collapse-disabled-color);
67

78
// font-size
89
@collapse-title-font: var(--td-collapse-title-font, @font-body-large);
@@ -13,7 +14,8 @@
1314
@collapse-horizontal-padding: var(--td-collapse-horizontal-padding, 32rpx);
1415
@collapse-content-padding: var(--td-collapse-content-padding, 32rpx);
1516
@collapse-border-color: var(--td-collapse-border-color, @border-level-1-color);
16-
@collapse-icon-color: var(--td-collapse-icon-color, @font-gray-3);
17+
@collapse-left-icon-color: var(--td-collapse-left-icon-color, @brand-color);
18+
@collapse-icon-color: var(--td-collapse-icon-color, @text-color-placeholder);
1719

1820
@collapse-panel-bg-color: var(--td-collapse-panel-bg-color, @bg-color-container);
1921

@@ -41,8 +43,6 @@
4143
align-items: center;
4244
padding-left: @collapse-horizontal-padding;
4345
height: @collapse-header-height;
44-
--td-cell-title-color: @collapse-header-text-color;
45-
--td-cell-left-icon-color: @collapse-icon-color;
4646

4747
&--top {
4848
.border(top, @collapse-border-color);
@@ -53,22 +53,7 @@
5353
}
5454

5555
&::after {
56-
left: 32rpx;
57-
}
58-
59-
&-right {
60-
display: inline-flex;
61-
align-items: center;
62-
height: 100%;
63-
}
64-
65-
&-icon {
66-
// 增大热区
67-
height: 100%;
68-
padding-left: 8px;
69-
width: 44px;
70-
padding-right: 8px;
71-
color: @collapse-icon-color;
56+
left: @spacer-2;
7257
}
7358
}
7459

@@ -91,7 +76,7 @@
9176
padding: @collapse-content-padding;
9277

9378
&--disabled {
94-
color: @text-color-disabled;
79+
color: @collapse-disabled-color;
9580
}
9681

9782
&--expanded&--bottom {
@@ -108,24 +93,27 @@
10893
}
10994
}
11095

96+
// cell: 统一用外部样式类自定义样式
11197
.class {
11298
&-title {
11399
font: @collapse-title-font;
100+
color: @collapse-header-text-color;
101+
}
114102

115-
&--disabled {
116-
color: @text-color-disabled;
117-
}
103+
&-left-icon {
104+
color: @collapse-left-icon-color;
118105
}
119106

120-
&-note {
121-
&--disabled {
122-
color: @text-color-disabled;
123-
}
107+
&-right-icon {
108+
color: @collapse-icon-color;
124109
}
125110

111+
&-title,
112+
&-note,
113+
&-left-icon,
126114
&-right-icon {
127115
&--disabled {
128-
color: @text-color-disabled;
116+
color: @collapse-disabled-color;
129117
}
130118
}
131119
}

packages/components/collapse-panel/collapse-panel.wxml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
t-class="{{_.cls(classPrefix + '__header', [placement, ['expanded', expanded]])}} {{prefix}}-class-header"
2121
t-class-title="class-title {{ultimateDisabled ? 'class-title--disabled' : ''}}"
2222
t-class-note="class-note {{ultimateDisabled ? 'class-note--disabled' : ''}}"
23+
t-class-left-icon="class-left-icon {{ultimateDisabled ? 'class-left-icon--disabled' : ''}}"
2324
t-class-right-icon="class-right-icon {{classPrefix}}__arrow--{{placement}} {{ultimateDisabled ? 'class-right-icon--disabled' : ''}}"
2425
t-class-hover="class-header-hover"
2526
>

packages/components/collapse/README.en-US.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,13 @@ Name | Default Value | Description
7272
--td-collapse-content-font | @font-body-medium | -
7373
--td-collapse-content-padding | 32rpx | -
7474
--td-collapse-content-text-color | @text-color-primary | -
75+
--td-collapse-disabled-color | @text-color-disabled | -
7576
--td-collapse-extra-font | @font-body-large | -
7677
--td-collapse-header-height | auto | -
7778
--td-collapse-header-text-color | @text-color-primary | -
78-
--td-collapse-header-text-disabled-color | @text-color-disabled | -
79+
--td-collapse-header-text-disabled-color | @collapse-disabled-color | -
7980
--td-collapse-horizontal-padding | 32rpx | -
80-
--td-collapse-icon-color | @font-gray-3 | -
81+
--td-collapse-icon-color | @text-color-placeholder | -
82+
--td-collapse-left-icon-color | @brand-color | -
8183
--td-collapse-panel-bg-color | @bg-color-container | -
8284
--td-collapse-title-font | @font-body-large | -

packages/components/collapse/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,13 @@ t-class-header | 头部样式类
126126
--td-collapse-content-font | @font-body-medium | -
127127
--td-collapse-content-padding | 32rpx | -
128128
--td-collapse-content-text-color | @text-color-primary | -
129+
--td-collapse-disabled-color | @text-color-disabled | -
129130
--td-collapse-extra-font | @font-body-large | -
130131
--td-collapse-header-height | auto | -
131132
--td-collapse-header-text-color | @text-color-primary | -
132-
--td-collapse-header-text-disabled-color | @text-color-disabled | -
133+
--td-collapse-header-text-disabled-color | @collapse-disabled-color | -
133134
--td-collapse-horizontal-padding | 32rpx | -
134-
--td-collapse-icon-color | @font-gray-3 | -
135+
--td-collapse-icon-color | @text-color-placeholder | -
136+
--td-collapse-left-icon-color | @brand-color | -
135137
--td-collapse-panel-bg-color | @bg-color-container | -
136138
--td-collapse-title-font | @font-body-large | -

packages/components/collapse/__test__/__snapshots__/index.test.js.snap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ exports[`collapse :defaultExpandAll 1`] = `
2323
<t-cell
2424
tClass="t-collapse-panel__header t-collapse-panel__header--bottom t-collapse-panel__header--expanded t-class-header"
2525
tClassHover="class-header-hover"
26+
tClassLeftIcon="class-left-icon "
2627
tClassNote="class-note "
2728
tClassRightIcon="class-right-icon t-collapse-panel__arrow--bottom "
2829
tClassTitle="class-title "
@@ -109,6 +110,7 @@ exports[`collapse :defaultExpandAll 1`] = `
109110
<t-cell
110111
tClass="t-collapse-panel__header t-collapse-panel__header--bottom t-collapse-panel__header--expanded t-class-header"
111112
tClassHover="class-header-hover"
113+
tClassLeftIcon="class-left-icon "
112114
tClassNote="class-note "
113115
tClassRightIcon="class-right-icon t-collapse-panel__arrow--bottom "
114116
tClassTitle="class-title "

packages/uniapp-components/collapse-panel/collapse-panel.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
@collapse-content-padding: var(--td-collapse-content-padding, 32rpx);
1515
@collapse-content-line-height: var(--td-collapse-content-line-height, 1.5);
1616
@collapse-border-color: var(--td-collapse-border-color, @border-level-1-color);
17-
@collapse-icon-color: var(--td-collapse-icon-color, @font-gray-3);
17+
@collapse-icon-color: var(--td-collapse-icon-color, @text-color-placeholder);
1818

1919
@collapse-panel-bg-color: var(--td-collapse-panel-bg-color, @bg-color-container);
2020

0 commit comments

Comments
 (0)