Skip to content

Commit aad4aed

Browse files
anlyyaotdesign-bot
andauthored
fix(Form): fix invalid requiredMark property (#4555)
* fix(Form): fix invalid requiredMark property * fix: fix cr * chore: stash changelog [ci skip] --------- Co-authored-by: tdesign-bot <tdesign@tencent.com>
1 parent 86aa6a8 commit aad4aed

4 files changed

Lines changed: 15 additions & 3 deletions

File tree

packages/components/form-item/form-item.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export default class FormItem extends SuperComponent {
8585
innerLabelWidth: normalizeLabelWidth(labelWidth || target.data.labelWidth),
8686
innerContentAlign,
8787
contentStyle: innerContentAlign ? `text-align: ${innerContentAlign}` : '',
88-
innerRequiredMark: requiredMark || target.data.requiredMark || globalConfig.requiredMark || isRequired,
88+
innerRequiredMark: requiredMark ?? target.data.requiredMark ?? globalConfig.requiredMark ?? isRequired,
8989
innerShowErrorMessage:
9090
typeof showErrorMessage === 'boolean' ? showErrorMessage : target.properties.showErrorMessage,
9191
requiredMarkPosition: target.data.requiredMarkPosition || globalConfig.requiredMarkPosition || 'left',
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
pr_number: 4555
3+
contributor: anlyyao
4+
---
5+
6+
- fix(Form): `FormRule.required` 为 true 时,`requiredMark` 属性无效 @anlyyao ([#4555](https://github.com/Tencent/tdesign-miniprogram/pull/4555))
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
pr_number: 4555
3+
contributor: anlyyao
4+
---
5+
6+
- fix(Form): `FormRule.required` 为 true 时,`requiredMark` 属性无效 @anlyyao ([#4555](https://github.com/Tencent/tdesign-miniprogram/pull/4555))

packages/uniapp-components/form-item/form-item.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ import { prefix } from '../common/config';
8080
8181
import { ChildrenMixin, RELATION_MAP } from '../common/relation';
8282
import { uniComponent } from '../common/src/index';
83-
import { getRect } from '../common/utils';
83+
import { coalesce, getRect } from '../common/utils';
8484
import tools from '../common/utils.wxs';
8585
import { isNumeric } from '../common/validator';
8686
import TIcon from '../icon/icon.vue';
@@ -187,7 +187,7 @@ export default {
187187
this.dataLabelAlign = labelAlign || target.labelAlign;
188188
this.dataLabelWidth = normalizeLabelWidth(labelWidth || target.labelWidth);
189189
this.dataContentAlign = contentAlign || target.contentAlign;
190-
this.dataRequiredMark = requiredMark || target.requiredMark || globalConfig.requiredMark || isRequired;
190+
this.dataRequiredMark = coalesce(requiredMark, target.requiredMark, globalConfig.requiredMark, isRequired);
191191
this.dataShowErrorMessage = typeof showErrorMessage === 'boolean' ? showErrorMessage : target.showErrorMessage;
192192
this.requiredMarkPosition = target.requiredMarkPosition || globalConfig.requiredMarkPosition || 'left';
193193
},

0 commit comments

Comments
 (0)