code review

Author: jkrrv

src/TouchPoint-WP/Taxonomies.php

@@ -73,13 +73,13 @@ protected static function getLabels(string $singular, string $plural): array
 	 *
 	 * @return void
 	 */
-	public static function insertTermsForArrayBasedTaxonomy(array $list, string $taxonomy, bool $forceIdUpdate)
+	public static function insertTermsForArrayBasedTaxonomy(array $list, string $taxonomy, bool $forceIdUpdate): void
 	{
 		$existingIds = [];
+		$idUpdate = $forceIdUpdate;
 		foreach ($list as $slug => $name) {
 			// In addition to making sure term exists, make sure it has the correct meta id, too.
 			$term = self::termExists($name, $taxonomy);
-			$idUpdate = $forceIdUpdate;
 			if ( ! $term) {
 				$term = self::insertTerm(
 					$name,
@@ -93,14 +93,16 @@ public static function insertTermsForArrayBasedTaxonomy(array $list, string $tax
 					new TouchPointWP_WPError($term);
 					$term = null;
 				}
-				if ($idUpdate) {
-					TouchPointWP::queueFlushRewriteRules();
-				}
+				$idUpdate = true;
+
 			}
 			if ( ! ! $term) {
 				$existingIds[] = $term['term_id'];
 			}
 		}
+		if ($idUpdate) {
+			TouchPointWP::queueFlushRewriteRules();
+		}
 
 		// Delete any terms that are no longer current.
 		$terms = get_terms(['taxonomy' => $taxonomy, 'hide_empty' => false, 'exclude' => $existingIds]);