Skip to content

Refresh Ambient Rings README screenshots#36

Merged
TerminallyLazy merged 2 commits into
mainfrom
codex/refresh-ambient-ring-screenshots
Jul 9, 2026
Merged

Refresh Ambient Rings README screenshots#36
TerminallyLazy merged 2 commits into
mainfrom
codex/refresh-ambient-ring-screenshots

Conversation

@TerminallyLazy

@TerminallyLazy TerminallyLazy commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • force a full Ratatui redraw when the TUI mode changes, preventing partial search and integrations frames
  • regenerate all four README screenshots from the current 47-memory TUI after transient activity pulses decay
  • document that lower relative ring fullness is duller and higher fullness is lighter

Verification

  • cargo test --locked (269 tests passed)
  • cargo clippy --locked --all-targets -- -D warnings
  • cargo fmt --check
  • git diff --check
  • visually inspected dashboard, search, evidence, and integrations captures at 1852x1266

Summary by CodeRabbit

  • Bug Fixes

    • Fixed stale terminal content that could remain visible when switching application modes.
    • Preserved the current display when no mode change occurs, improving terminal rendering stability.
  • Documentation

    • Expanded the dashboard screenshot description to explain ambient ring layers and temporary activity pulses.

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@TerminallyLazy, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 25f814f0-0d84-475e-bcb8-c35d8844d9af

📥 Commits

Reviewing files that changed from the base of the PR and between 5e8be25 and 327fb04.

📒 Files selected for processing (1)
  • crates/tree-ring-memory-cli/src/tui/mod.rs
📝 Walkthrough

Walkthrough

The TUI now clears stale terminal content when AppMode changes, with tests for changed and unchanged modes. The dashboard screenshot caption now explains ambient-layer behavior and temporary activity pulses.

Changes

TUI and documentation updates

Layer / File(s) Summary
Mode-aware terminal clearing
crates/tree-ring-memory-cli/src/tui/mod.rs
run_loop detects mode changes and conditionally clears the terminal; unit tests verify both outcomes.
Dashboard screenshot caption
README.md
The caption describes ambient-layer changes based on fullness and memory share, plus temporary activity pulses.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the README screenshot refresh, which is a main part of the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/refresh-ambient-ring-screenshots

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README documentation and introduces terminal clearing on application mode changes in the TUI to prevent rendering artifacts. The feedback highlights that mode changes occurring during app.tick() (outside of key events) will not trigger a terminal clear, and suggests tracking and handling mode changes across both key events and tick updates to ensure robustness.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines 41 to 51
if let terminal_event::Event::Key(key) =
terminal_event::read().map_err(|err| err.to_string())?
{
let previous_mode = app.mode;
app.handle_key(key)?;
clear_on_mode_change(terminal, previous_mode, app.mode)
.map_err(|err| err.to_string())?;
}
}
app.tick()?;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Currently, clear_on_mode_change is only invoked when a key event is processed. If the application mode changes during app.tick() (for example, due to background stream events, timeouts, or other asynchronous updates), the terminal will not be cleared, potentially leading to stale or partial frames.

To make this more robust, we should track and handle mode changes across both key event processing and the tick update.

            let previous_mode = app.mode;
            if let terminal_event::Event::Key(key) =
                terminal_event::read().map_err(|err| err.to_string())?
            {
                app.handle_key(key)?;
            }
            clear_on_mode_change(terminal, previous_mode, app.mode)
                .map_err(|err| err.to_string())?;
        }
        let previous_mode = app.mode;
        app.tick()?;
        clear_on_mode_change(terminal, previous_mode, app.mode)
            .map_err(|err| err.to_string())?;
    }

@TerminallyLazy TerminallyLazy merged commit 8206464 into main Jul 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant