Skip to content

Commit 125ba1e

Browse files
authored
Merge pull request #770 from ZacharyZcR/fix/default-session-persistence
fix: enable terminal session persistence by default
2 parents d74e1b1 + dd0bfb5 commit 125ba1e

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/ui/features/terminal/Terminal.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -955,7 +955,7 @@ const TerminalInner = forwardRef<TerminalHandle, SSHTerminalProps>(
955955
currentHostConfigRef.current = hostConfig;
956956

957957
const persistenceEnabled =
958-
localStorage.getItem("enableTerminalSessionPersistence") === "true";
958+
localStorage.getItem("enableTerminalSessionPersistence") !== "false";
959959
const tabId = hostConfig.instanceId
960960
? `${hostConfig.id}_${hostConfig.instanceId}`
961961
: `${hostConfig.id}_${Date.now()}`;
@@ -1456,8 +1456,8 @@ const TerminalInner = forwardRef<TerminalHandle, SSHTerminalProps>(
14561456
} else if (msg.type === "sessionCreated") {
14571457
sessionIdRef.current = msg.sessionId;
14581458
const persistenceEnabled =
1459-
localStorage.getItem("enableTerminalSessionPersistence") ===
1460-
"true";
1459+
localStorage.getItem("enableTerminalSessionPersistence") !==
1460+
"false";
14611461
if (persistenceEnabled && hostConfig.instanceId) {
14621462
const tabId = `${hostConfig.id}_${hostConfig.instanceId}`;
14631463
localStorage.setItem(`termix_session_${tabId}`, msg.sessionId);
@@ -2144,7 +2144,7 @@ const TerminalInner = forwardRef<TerminalHandle, SSHTerminalProps>(
21442144
}
21452145

21462146
const persistenceEnabled =
2147-
localStorage.getItem("enableTerminalSessionPersistence") === "true";
2147+
localStorage.getItem("enableTerminalSessionPersistence") !== "false";
21482148
if (
21492149
!persistenceEnabled &&
21502150
sessionIdRef.current &&

src/ui/shell/TabContext.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export function TabProvider({ children }: TabProviderProps) {
9696
const isElectron =
9797
typeof window !== "undefined" && !!(window as ElectronWindow).electronAPI;
9898
const persistenceEnabled =
99-
localStorage.getItem("enableTerminalSessionPersistence") === "true";
99+
localStorage.getItem("enableTerminalSessionPersistence") !== "false";
100100
const shouldRestore = isMobile || isElectron || persistenceEnabled;
101101

102102
if (!shouldRestore) {
@@ -165,7 +165,7 @@ export function TabProvider({ children }: TabProviderProps) {
165165
const isElectron =
166166
typeof window !== "undefined" && !!(window as ElectronWindow).electronAPI;
167167
const persistenceEnabled =
168-
localStorage.getItem("enableTerminalSessionPersistence") === "true";
168+
localStorage.getItem("enableTerminalSessionPersistence") !== "false";
169169
const shouldSave = isMobile || isElectron || persistenceEnabled;
170170

171171
if (shouldSave) {

src/ui/sidebar/UserProfilePanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ export function UserProfilePanel({
465465
return v !== null ? v === "true" : true;
466466
});
467467
const [sessionPersistence, setSessionPersistence] = useState(
468-
() => localStorage.getItem("enableTerminalSessionPersistence") === "true",
468+
() => localStorage.getItem("enableTerminalSessionPersistence") !== "false",
469469
);
470470
const [showHostTags, setShowHostTags] = useState(() => {
471471
const v = localStorage.getItem("showHostTags");

0 commit comments

Comments
 (0)