Conversation
Contributor
|
Keep in mind that the package.json is autogenerated. You have to change the
things here:
https://github.com/TerosTechnology/vscode-terosHDL/tree/dev/auto_package
And to run gen.sh For example for the version:
https://github.com/TerosTechnology/vscode-terosHDL/blob/dev/auto_package/templates/info.nj
El sáb, 13 dic 2025, 7:34, G. Martin ***@***.***> escribió:
… Using iconThemes removes the icons for other files.
Better assing icons to languages to override icons.
Before
image.png (view on web)
<https://github.com/user-attachments/assets/62f33644-6276-4808-ba4d-cd464be3234b>
After
image.png (view on web)
<https://github.com/user-attachments/assets/0cf6ee35-5067-4bfa-aeb1-a7f39ffd0407>
------------------------------
You can view, comment on, or merge this pull request online at:
#839
Commit Summary
- 0f66523
<0f66523>
add file icon support and commands to enable/disable icons
- f46728a
<f46728a>
enable TerosHDL file icons by default
- f086639
<f086639>
remove file icon enable/disable commands from Comander
- fe561d2
<fe561d2>
add missing newline at end of file in Comander class
- 436ade2
<436ade2>
remove icon theme. Now icons override default icon theme
- eb48a41
<eb48a41>
Merge branch 'dev' into feature/add-icons
- 82558b3
<82558b3>
fix after dev pull
File Changes
(2 files
<https://github.com/TerosTechnology/vscode-terosHDL/pull/839/files>)
- *M* package.json
<https://github.com/TerosTechnology/vscode-terosHDL/pull/839/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519>
(180)
- *D* resources/icon/teroshdl-icon-theme.json
<https://github.com/TerosTechnology/vscode-terosHDL/pull/839/files#diff-d2627a59783731fb7709c5b3f027b771dcf3dc2712da435458282fc8e9cc4da1>
(122)
Patch Links:
- https://github.com/TerosTechnology/vscode-terosHDL/pull/839.patch
- https://github.com/TerosTechnology/vscode-terosHDL/pull/839.diff
—
Reply to this email directly, view it on GitHub
<#839>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNN4R4IUCYBDLLS4EXLM6T4BOXOVAVCNFSM6AAAAACO5PR6MKVHI2DSMVQWIX3LMV43ASLTON2WKOZTG4ZDKNJZGIZTENI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
Author
|
@qarlosalberto new PR: #840 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using iconThemes removes the icons for other files.
Better assigning icons to languages to override default icon theme.
Before
After