enhancement: Chore/code cleanup (#133)

* refactor: streamline test run case handling in TestPlanItReporter

- Removed unnecessary variable declarations and simplified the logic for retrieving or creating test run cases.
- Enhanced logging to provide clearer feedback when cases are added to the run.
- Cleaned up unused variables and improved code readability across multiple files.

* refactor: simplify data handling and improve readability across components

- Removed unnecessary fallback values in data assignments to enhance clarity.
- Streamlined conditional checks and improved logic for better performance.
- Cleaned up unused variables and optimized component rendering in various files.

Author: therealbrad

packages/wdio-testplanit-reporter/src/reporter.ts

@@ -888,19 +888,15 @@ export default class TestPlanItReporter extends WDIOReporter {
       }
 
       // Get or create test run case
-      let testRunCaseId: number | undefined;
       const runCaseKey = `${this.state.testRunId}_${repositoryCaseId}`;
 
-      if (this.state.testRunCaseMap.has(runCaseKey)) {
-        testRunCaseId = this.state.testRunCaseMap.get(runCaseKey);
-      } else {
+      if (!this.state.testRunCaseMap.has(runCaseKey)) {
         const testRunCase = await this.client.findOrAddTestCaseToRun({
           testRunId: this.state.testRunId,
           repositoryCaseId,
         });
-        testRunCaseId = testRunCase.id;
-        this.state.testRunCaseMap.set(runCaseKey, testRunCaseId);
-        this.log('Added case to run:', testRunCaseId);
+        this.state.testRunCaseMap.set(runCaseKey, testRunCase.id);
+        this.log('Added case to run:', testRunCase.id);
       }
 
       // Get status ID for the JUnit result

testplanit/app/[locale]/admin/api-tokens/page.tsx

@@ -447,7 +447,7 @@ function ApiTokensList() {
             {tokens && tokens.length > 0 ? (
               <DataTable<ExtendedApiToken, unknown>
                 columns={columns}
-                data={tokens || []}
+                data={tokens}
                 onSortChange={handleSortChange}
                 sortConfig={sortConfig}
                 columnVisibility={columnVisibility}

testplanit/app/[locale]/admin/imports/TestmoImportPanel.tsx

@@ -1073,13 +1073,6 @@ export function TestmoImportPanel() {
       return false;
     }
 
-    if (!storageKey) {
-      setProcessingState("idle");
-      setUploadProgress({ state: "idle", percent: 0 });
-      setErrorKey("upload-failed");
-      return false;
-    }
-
     let success = false;
     try {
       setProcessingState("analyzing");

testplanit/app/[locale]/admin/projects/ProjectGroupPermissions.tsx

@@ -152,7 +152,6 @@ export function ProjectGroupPermissions({
                 return null;
               }
 
-              let effectiveAccessDisplay = "";
               let combinedValue = ""; // For the Select component value
 
               const currentAccessType = permission.accessType;
@@ -161,27 +160,22 @@ export function ProjectGroupPermissions({
               // Determine the current combined value for the select dropdown
               if (currentAccessType === "PROJECT_DEFAULT") {
                 combinedValue = "PROJECT_DEFAULT";
-                effectiveAccessDisplay = tGlobal("common.labels.access.projectDefault");
               } else if (currentAccessType === ProjectAccessType.NO_ACCESS) {
                 combinedValue = "NO_ACCESS";
-                effectiveAccessDisplay = tGlobal("common.labels.access.noAccess");
               } else if (currentAccessType === ProjectAccessType.GLOBAL_ROLE) {
                 combinedValue = "GLOBAL_ROLE";
-                effectiveAccessDisplay = tGlobal("common.labels.access.usersGlobalRole");
               } else if (
                 currentAccessType === ProjectAccessType.SPECIFIC_ROLE &&
                 currentRoleId &&
                 currentRoleId !== "NONE"
               ) {
                 combinedValue = `ROLE_${currentRoleId}`;
-                effectiveAccessDisplay = tGlobal("common.labels.access.specificRole");
               } else {
                 // Fallback or inconsistent state - default to Project Default display
                 console.warn(
                   `Inconsistent permission state for group ${groupIdStr}: accessType=${currentAccessType}, roleId=${currentRoleId}`
                 );
                 combinedValue = "PROJECT_DEFAULT";
-                effectiveAccessDisplay = tGlobal("common.labels.access.projectDefault");
               }
 
               return (

testplanit/app/[locale]/projects/repository/[projectId]/BulkEditModal.tsx

@@ -1155,11 +1155,9 @@ export function BulkEditModal({
             schema = strSchema.nullable(); // Allow null/empty string if not required
             break;
           case "Text Long":
-            // Start with string, apply nullability/parsing later
-            let textSchema: z.ZodTypeAny = z.string();
-
             if (isRequired) {
-              textSchema = textSchema.refine(
+              // If required, it must be a non-empty, valid JSON string.
+              schema = z.string().refine(
                 (val) => {
                   if (!val) return false;
                   try {
@@ -1173,8 +1171,6 @@ export function BulkEditModal({
                 },
                 { message: "Content is required" }
               );
-              // If required, it must be a non-empty, valid JSON string.
-              // Nullable is handled separately.
             } else {
               // If not required, allow null/undefined, OR valid JSON string (can be empty)
               schema = z

testplanit/app/[locale]/projects/repository/[projectId]/FieldValueInput.tsx

@@ -432,10 +432,10 @@ export function FieldValueInput({
       );
 
     case "Text Long":
-      let initialTextContent = emptyEditorContent;
+      let initialTextContent;
       try {
         initialTextContent = value ? JSON.parse(value) : emptyEditorContent;
-      } catch (error) {
+      } catch {
         initialTextContent = emptyEditorContent;
       }
 

testplanit/app/[locale]/projects/repository/[projectId]/StepsForm.tsx

@@ -815,8 +815,7 @@ const StepsForm: React.FC<StepsFormProps> = ({
     }
     const lowerCaseQuery = query.toLowerCase();
     // Correctly treat allSharedStepGroupsData as a direct array
-    const typedData = (allSharedStepGroupsData ||
-      []) as SharedStepGroupWithCount[];
+    const typedData = allSharedStepGroupsData as SharedStepGroupWithCount[];
 
     const filtered = typedData.filter((group) =>
       group.name.toLowerCase().includes(lowerCaseQuery)
@@ -910,7 +909,7 @@ const StepsForm: React.FC<StepsFormProps> = ({
               >
                 <Layers className="h-5 w-5" />
                 {tRepoSteps("createSharedSteps", {
-                  number: selectedStepIndices.length || 0,
+                  number: selectedStepIndices.length,
                 })}
               </Button>
             )}

testplanit/app/[locale]/projects/repository/[projectId]/[caseId]/page.tsx

@@ -1756,7 +1756,7 @@ export default function TestCaseDetails() {
                           type="button"
                           variant="outline"
                           onClick={handleCancel}
-                          disabled={isSubmitting || isLoadingSharedStepGroups}
+                          disabled={isLoadingSharedStepGroups}
                         >
                           <div className="flex items-center">
                             <CircleSlash2 className="w-5 h-5 mr-2" />

testplanit/app/[locale]/projects/runs/[projectId]/DuplicateTestRunDialog.tsx

@@ -343,7 +343,7 @@ const DuplicateTestRunDialog: React.FC<DuplicateTestRunDialogProps> = ({
   if (!open) return null;
   if (
     isLoadingOriginalRun ||
-    (open && !testRunCasesDataForStatusList && isLoadingCasesForStatusList)
+    (!testRunCasesDataForStatusList && isLoadingCasesForStatusList)
   ) {
     return (
       <Dialog open={open} onOpenChange={onOpenChange}>

testplanit/app/[locale]/projects/runs/[projectId]/[runId]/TestRunFormControls.tsx

@@ -409,7 +409,7 @@ function TestRunFormControls({
                     issueTypeIconUrl={issue.issueTypeIconUrl}
                   />
                 ))
-              : !isEditMode && (
+              : (
                   <span className="text-muted-foreground text-sm">
                     {t("common.access.none")}
                   </span>