fix(seed): preserve admin-selected defaults across re-seeds (#468)

The Prisma seed runs on every app boot/upgrade and was force-resetting
default flags, silently reverting an admin's choices with no audit trail
(seed uses the raw Prisma client and bypasses the audit hooks).

Apply the seedDefaultTemplate pattern to every affected seeder: only set a
default on fresh install (no active default exists) and never overwrite the
flag on update.

- PromptConfig: drop the blanket updateMany demotion; set default only on
  fresh install; do not touch isDefault on update.
- Roles: stop forcing user->default / admin->non-default on update.
- Workflows: track existing defaults per scope; only seed a default for a
  scope that has none yet; do not touch isDefault on update.
- MilestoneTypes: do not touch isDefault on update; seed default only on
  fresh install.

Each seeder logs when it preserves an admin's existing choice.

Author: therealbrad

testplanit/prisma/seed.ts

@@ -60,22 +60,36 @@ async function seedCoreData() {
   console.log("Seeding core data...");
 
   // --- Roles ---
+  // Respect the admin's explicit default-role choice. The seed runs on every
+  // upgrade, and previously the `update` blocks force-reset "user" to default
+  // and "admin" to non-default, silently overwriting whatever role the admin
+  // had picked as the default for new users. (Mirrors seedDefaultTemplate.)
+  // Only install "user" as the default when no default role exists yet.
+  const existingDefaultRole = await prisma.roles.findFirst({
+    where: { isDefault: true },
+    select: { id: true, name: true },
+  });
   const userRole = await prisma.roles.upsert({
     where: { name: "user" },
-    update: { isDefault: true },
+    update: {}, // do NOT touch isDefault — preserve the admin's choice
     create: {
       name: "user",
-      isDefault: true,
+      isDefault: existingDefaultRole === null,
     },
   });
   const adminRole = await prisma.roles.upsert({
     where: { name: "admin" },
-    update: { isDefault: false },
+    update: {}, // do NOT touch isDefault — preserve the admin's choice
     create: {
       name: "admin",
       isDefault: false,
     },
   });
+  if (existingDefaultRole && existingDefaultRole.name !== "user") {
+    console.log(
+      `Skipped re-promoting "user" role to default — admin's choice "${existingDefaultRole.name}" preserved.`
+    );
+  }
 
   console.log(
     `Upserted roles: admin (ID: ${adminRole.id}), user (ID: ${userRole.id}) - Default: ${userRole.isDefault ? "user" : "admin"}`
@@ -1422,6 +1436,21 @@ async function seedWorkflows() {
     },
   ];
 
+  // Respect the admin's per-scope default-status choice. The seed runs on
+  // every upgrade, and previously the `update` block force-reset `isDefault`
+  // from the seed data, silently overwriting whichever workflow status the
+  // admin had picked as the default for each scope. (Mirrors the fix in
+  // seedDefaultTemplate.) Only install a seed default for a scope that has no
+  // default yet (fresh install or a newly-introduced scope).
+  const existingDefaultScopes = new Set<string>(
+    (
+      await prisma.workflows.findMany({
+        where: { isDefault: true },
+        select: { scope: true },
+      })
+    ).map((w) => w.scope)
+  );
+
   for (const workflow of workflowsData) {
     const icon = await prisma.fieldIcon.findUnique({
       where: { name: workflow.icon },
@@ -1452,7 +1481,7 @@ async function seedWorkflows() {
             iconId: icon.id,
             colorId: color.id,
             isEnabled: workflow.isEnabled,
-            isDefault: workflow.isDefault,
+            // Do NOT touch isDefault — preserve the admin's choice.
           },
         });
       } else {
@@ -1463,7 +1492,8 @@ async function seedWorkflows() {
             iconId: icon.id,
             colorId: color.id,
             isEnabled: workflow.isEnabled,
-            isDefault: workflow.isDefault,
+            isDefault:
+              workflow.isDefault && !existingDefaultScopes.has(workflow.scope),
             scope: workflow.scope as WorkflowScope,
             workflowType: workflow.workflowType as
               | "NOT_STARTED"
@@ -1542,19 +1572,30 @@ async function seedMilestoneTypes() {
 
   const milestoneTypesWithIconIds = await Promise.all(iconPromises);
 
+  // Respect the admin's explicit default milestone-type choice. The seed runs
+  // on every upgrade, and previously the `update` block force-reset
+  // `isDefault` from the seed data, silently overwriting the admin's choice.
+  // (Mirrors the fix in seedDefaultTemplate.) Only install the seed default
+  // when no default milestone type exists yet (fresh install).
+  const existingDefaultMilestoneType = await prisma.milestoneTypes.findFirst({
+    where: { isDefault: true },
+    select: { id: true },
+  });
+
   const milestoneTypePromises = milestoneTypesWithIconIds.map((type) =>
     prisma.milestoneTypes.upsert({
       where: { id: type.id },
       update: {
         name: type.name,
         iconId: type.iconId,
-        isDefault: type.isDefault || false,
+        // Do NOT touch isDefault — preserve the admin's choice.
       },
       create: {
         id: type.id,
         name: type.name,
         iconId: type.iconId,
-        isDefault: type.isDefault || false,
+        isDefault:
+          (type.isDefault || false) && existingDefaultMilestoneType === null,
       },
     })
   );

testplanit/prisma/seedPromptConfig.ts

@@ -8,26 +8,43 @@ import { LLM_FEATURES, PROMPT_FEATURE_VARIABLES } from "../lib/llm/constants";
 export async function seedDefaultPromptConfig(prisma: PrismaClient) {
   console.log("Seeding default prompt configuration...");
 
-  // Ensure no other config is marked as default (safety measure)
-  await prisma.promptConfig.updateMany({
-    where: { isDefault: true },
-    data: { isDefault: false },
+  // Respect the admin's explicit default choice. The seed runs on every
+  // application upgrade, and previously this function force-demoted every
+  // `isDefault: true` row and then re-promoted "Default", silently
+  // overwriting whatever config the admin had picked as the default — with
+  // no audit trail, because seed uses the raw prisma client and bypasses the
+  // `$extends` audit middleware. (Mirrors the fix in seedDefaultTemplate.)
+  //
+  // New rule: ONLY mark "Default" as the default when the tenant has no
+  // active default config at all (fresh install). Otherwise create / update
+  // the row without touching its `isDefault` flag.
+  const existingDefault = await prisma.promptConfig.findFirst({
+    where: { isDefault: true, isActive: true, isDeleted: false },
+    select: { id: true, name: true },
   });
 
-  // Create or update the default prompt config
+  // Create or update the default prompt config. On first install (no existing
+  // default) mark it as the default; on upgrades the `update` block runs and
+  // `isDefault` is NOT touched, preserving whatever the admin chose.
   const defaultConfig = await prisma.promptConfig.upsert({
     where: { name: "Default" },
-    update: { isDefault: true, isActive: true, isDeleted: false },
+    update: { isActive: true, isDeleted: false },
     create: {
       name: "Default",
       description:
         "Default prompt configuration with standard prompts for all AI features.",
-      isDefault: true,
+      isDefault: existingDefault === null,
       isActive: true,
       isDeleted: false,
     },
   });
 
+  if (existingDefault && existingDefault.name !== "Default") {
+    console.log(
+      `Skipped re-promoting "Default" prompt config — admin's choice "${existingDefault.name}" preserved.`
+    );
+  }
+
   // Define prompts for each feature
   const featurePrompts = [
     {