fix(dry-run): include failed run-scoped step sample

Author: JerryNee

src/commands/test.test.ts

@@ -2667,6 +2667,40 @@ describe('runSteps', () => {
     expect(block.match(/error: /g)).toHaveLength(1);
   });
 
+  it('--run-id dry-run sample maps the failed step error and failure contributor flag', async () => {
+    const out: string[] = [];
+    const page = await runSteps(
+      {
+        profile: 'default',
+        output: 'json',
+        debug: false,
+        dryRun: true,
+        testId: 'test_fe',
+        runId: 'run_dry',
+      },
+      {
+        env: {} as NodeJS.ProcessEnv,
+        credentialsPath: join(tmpdir(), 'testsprite-no-creds'),
+        stdout: line => out.push(line),
+        stderr: () => undefined,
+      },
+    );
+
+    const failing = page.items.find(step => step.stepIndex === 3);
+    expect(failing).toMatchObject({
+      status: 'failed',
+      error: expect.any(String),
+      stepType: 'assertion',
+      outcomeContributesToFailure: true,
+    });
+    expect(page.items.find(step => step.stepIndex === 1)?.outcomeContributesToFailure).toBe(false);
+
+    const printed = JSON.parse(out[0]!) as { items: Array<{ stepIndex: number; error?: string }> };
+    expect(printed.items.some(step => step.stepIndex === 3 && typeof step.error === 'string')).toBe(
+      true,
+    );
+  });
+
   it('--run-id: rejects a runId that belongs to a different test (exit 4)', async () => {
     const { credentialsPath } = makeCreds();
     // The run-scoped endpoint returns a run whose testId differs from the

src/lib/dry-run/samples.test.ts

@@ -407,20 +407,41 @@ describe('findSample', () => {
     expect(e).toBeUndefined();
   });
 
-  // defect-2 fix: getRun sample must return the passed shape (first-match-wins
-  // in findSample). Prior to fix, a duplicate failed-shape entry appeared
-  // before the passed-shape entry; `test wait --dry-run` always resolved to
-  // status: "failed", giving agents the wrong happy-path canned response.
-  it('GET /runs/{runId} resolves to the passed-shape getRun (not the failed shape)', () => {
+  it('GET /runs/{runId} sample includes a failed run-scoped step', () => {
     const e = findSample('GET', 'https://api.testsprite.com/api/cli/v1/runs/run_xyz');
     expect(e?.operationId).toBe('getRun');
     const body = e?.body() as {
       status: string;
       runId: string;
-      stepSummary: { failedCount: number };
+      failedStepIndex: number | null;
+      failureKind: string | null;
+      error: string | null;
+      stepSummary: { total: number; completed: number; passedCount: number; failedCount: number };
+      steps: Array<{
+        stepIndex: string;
+        type: string;
+        status: string | null;
+        error: string | null;
+      }>;
     };
-    expect(body.status).toBe('passed');
-    expect(body.stepSummary.failedCount).toBe(0);
+    expect(body.status).toBe('failed');
+    expect(body.failedStepIndex).toBe(3);
+    expect(body.failureKind).toBe('assertion');
+    expect(body.error).toEqual(expect.any(String));
+    expect(body.stepSummary).toMatchObject({
+      total: 3,
+      completed: 3,
+      passedCount: 2,
+      failedCount: 1,
+    });
+
+    const failingStep = body.steps.find(step => step.stepIndex === '0003');
+    expect(failingStep).toMatchObject({
+      type: 'assertion',
+      status: 'failed',
+      error: expect.any(String),
+    });
+    expect(failingStep?.error).not.toBe('');
   });
 
   it('getTest sample carries priority field (G1a)', () => {

src/lib/dry-run/samples.ts

@@ -691,37 +691,35 @@ const ENTRIES: DryRunSampleEntry[] = [
     },
   } satisfies BatchRerunResponse),
   // M3.3 piece-3 — GET /runs/{runId} (live status / long-poll).
-  // A terminal `passed` row is the most useful dry-run shape: agents see
-  // what a completed run looks like, and `--wait` terminates immediately.
-  // fix(2026-05-21): a duplicate failed-shape entry that appeared before
-  // this entry was removed; findSample first-match-wins was always
-  // returning status: "failed" for `test wait --dry-run`.
+  // Use a terminal failed row with a concrete failed step so
+  // `test steps --run-id <id> --dry-run` demonstrates the run-scoped
+  // error + failedStepIndex mapping without needing live credentials.
   entry('getRun', 'GET', '/runs/{runId}', {
     runId: SAMPLE_RUN_ID,
-    testId: SAMPLE_TEST_ID_PASSED,
+    testId: SAMPLE_TEST_ID_FAILED,
     projectId: SAMPLE_PROJECT_ID,
     userId: SAMPLE_USER_ID,
-    status: 'passed',
+    status: 'failed',
     source: 'cli',
     createdAt: '2026-05-15T19:32:00.000Z',
     startedAt: '2026-05-15T19:32:05.000Z',
     finishedAt: '2026-05-15T19:34:00.000Z',
     codeVersion: 'v1',
     targetUrl: SAMPLE_TARGET_URL,
     createdFrom: null,
-    failedStepIndex: null,
-    failureKind: null,
-    error: null,
+    failedStepIndex: 3,
+    failureKind: 'assertion',
+    error: 'Expected billing status badge to be visible, but it was not found.',
     videoUrl: null,
     stepSummary: {
-      total: 8,
-      completed: 8,
-      passedCount: 8,
-      failedCount: 0,
+      total: 3,
+      completed: 3,
+      passedCount: 2,
+      failedCount: 1,
     },
     // Representative per-run steps so `test steps --run-id <id> --dry-run`
     // demonstrates real output instead of an empty list (the generic
-    // `/runs/{runId}` sample is also used by `test wait`, which ignores steps).
+    // `/runs/{runId}` sample is also safe for wait flows, which ignore steps).
     steps: [
       {
         stepIndex: '0001',
@@ -745,6 +743,17 @@ const ENTRIES: DryRunSampleEntry[] = [
         htmlSnapshotUrl: null,
         createdAt: '2026-05-15T19:32:20.000Z',
       },
+      {
+        stepIndex: '0003',
+        type: 'assertion',
+        action: 'assert_visible',
+        status: 'failed',
+        description: 'Billing status badge is visible',
+        error: 'Expected billing status badge to be visible, but it was not found.',
+        screenshotUrl: null,
+        htmlSnapshotUrl: null,
+        createdAt: '2026-05-15T19:32:30.000Z',
+      },
     ],
   } satisfies RunResponse),
 ];