fix: tighten project env fallback

Author: naufalfx805-source

src/commands/test.run.spec.ts

@@ -2582,6 +2582,9 @@ describe('runTestRunAll — batch fresh run', () => {
     await expect(test.parseAsync(['run', '--all'], { from: 'user' })).rejects.toMatchObject({
       code: 'VALIDATION_ERROR',
       exitCode: 5,
+      details: expect.objectContaining({
+        reason: expect.stringContaining('TESTSPRITE_PROJECT_ID'),
+      }),
     });
   });
 
@@ -2607,6 +2610,30 @@ describe('runTestRunAll — batch fresh run', () => {
     const post = captured.find(c => c.method === 'POST' && c.url.includes('/tests/batch/run'))!;
     expect(post.body).toMatchObject({ projectId: 'project_env', source: 'cli' });
   });
+
+  it('run --all uses TESTSPRITE_PROJECT_ID when --project is blank', async () => {
+    const { createTestCommand } = await import('./test.js');
+    const { credentialsPath } = makeCreds();
+    type Captured = { url: string; method: string; body: unknown };
+    const captured: Captured[] = [];
+    const fetchImpl = makeFetch((url, init) => {
+      const method = init.method ?? 'GET';
+      captured.push({ url, method, body: init.body ? JSON.parse(init.body as string) : undefined });
+      return { body: BATCH_FRESH_RESP };
+    });
+    const test = createTestCommand({
+      credentialsPath,
+      env: { TESTSPRITE_PROJECT_ID: 'project_env' } as NodeJS.ProcessEnv,
+      fetchImpl,
+      stdout: () => undefined,
+      stderr: () => undefined,
+      sleep: instantSleep,
+    });
+    await test.parseAsync(['run', '--all', '--project', '   '], { from: 'user' });
+    const post = captured.find(c => c.method === 'POST' && c.url.includes('/tests/batch/run'))!;
+    expect(post.body).toMatchObject({ projectId: 'project_env', source: 'cli' });
+  });
+
   it('--all --target-url → exit 5 (target-url has no effect on BE-only batch)', async () => {
     const { createTestCommand } = await import('./test.js');
     const test = createTestCommand();

src/commands/test.test.ts

@@ -384,6 +384,25 @@ describe('runList', () => {
     expect(seen[0]).toContain('projectId=project_env');
   });
 
+  it('uses TESTSPRITE_PROJECT_ID when --project is blank', async () => {
+    const { credentialsPath } = makeCreds();
+    const seen: string[] = [];
+    const fetchImpl = makeFetch(url => {
+      seen.push(url);
+      return { body: { items: [FE_TEST], nextToken: null } };
+    });
+    await runList(
+      { profile: 'default', output: 'json', debug: false, projectId: '   ' },
+      {
+        credentialsPath,
+        env: { TESTSPRITE_PROJECT_ID: 'project_env' } as NodeJS.ProcessEnv,
+        fetchImpl,
+        stdout: () => undefined,
+      },
+    );
+    expect(seen[0]).toContain('projectId=project_env');
+  });
+
   it('prefers explicit --project over TESTSPRITE_PROJECT_ID', async () => {
     const { credentialsPath } = makeCreds();
     const seen: string[] = [];
@@ -822,10 +841,15 @@ describe('createTestCommand list — required flag', () => {
       await test.parseAsync(['list'], { from: 'user' });
       expect.unreachable('expected ApiError');
     } catch (err) {
-      const apiErr = err as { code?: string; exitCode?: number; details?: { field?: string } };
+      const apiErr = err as {
+        code?: string;
+        exitCode?: number;
+        details?: { field?: string; reason?: string };
+      };
       expect(apiErr.code).toBe('VALIDATION_ERROR');
       expect(apiErr.exitCode).toBe(5);
       expect(apiErr.details?.field).toBe('project');
+      expect(apiErr.details?.reason).toContain('TESTSPRITE_PROJECT_ID');
     }
   });
 

src/commands/test.ts

@@ -9161,18 +9161,16 @@ export function createTestCommand(deps: TestDeps = {}): Command {
       if (isAll) {
         // --all path: wave-ordered fresh batch run.
         const projectId = resolveProjectId(cmdOpts.project, deps);
-        if (!projectId) {
-          throw localValidationError(
-            'project',
-            '--all requires a project id - pass --project <id> or set TESTSPRITE_PROJECT_ID',
-          );
-        }
+        requireProjectId(
+          projectId,
+          '--all requires a project id - pass --project <id> or set TESTSPRITE_PROJECT_ID',
+        );
         // --target-url has no effect on the --all batch path: a BE test's base
         // URL is baked into its code, and the unified engine resolves each
         // project's configured environment server-side (per-run URL overrides
         // are not applied to batch FE runs either). Silently dropping it could
-        // run the suite against an unintended environment in the caller's mind
-        // — reject loudly instead.
+        // run the suite against an unintended environment in the caller's mind,
+        // so reject loudly.
         if (cmdOpts.targetUrl !== undefined && cmdOpts.targetUrl !== '') {
           throw localValidationError(
             'target-url',
@@ -9792,14 +9790,18 @@ interface StepsFlagOpts {
 }
 
 function resolveProjectId(projectId: string | undefined, deps: TestDeps): string | undefined {
-  if (projectId !== undefined) return projectId;
+  const explicit = projectId?.trim();
+  if (explicit && explicit.length > 0) return explicit;
   const envValue = (deps.env ?? process.env).TESTSPRITE_PROJECT_ID;
   const trimmed = envValue?.trim();
   return trimmed && trimmed.length > 0 ? trimmed : undefined;
 }
-function requireProjectId(projectId: string | undefined): asserts projectId is string {
+function requireProjectId(
+  projectId: string | undefined,
+  message = 'is required; pass --project <id> or set TESTSPRITE_PROJECT_ID',
+): asserts projectId is string {
   if (typeof projectId !== 'string' || projectId.length === 0) {
-    throw localValidationError('project', 'is required');
+    throw localValidationError('project', message);
   }
 }