fix(open): derive the dry-run URL via resolvePortalUrl and handle async spawn ENOENT

Author: Andy00L

src/commands/test.ts

@@ -3880,8 +3880,14 @@ export async function runOpen(
 
   if (opts.dryRun) {
     emitDryRunBanner(stderrFn);
+    // Derive the sample through the SAME resolver as the live path (against
+    // the canonical prod endpoint and the dry-run project id) so the two can
+    // never drift; the ?? arm is unreachable for the prod mapping but keeps
+    // the type total.
     const sample = {
-      dashboardUrl: `https://www.testsprite.com/dashboard/tests/p_dryrun_2026/test/${opts.testId}`,
+      dashboardUrl:
+        resolvePortalUrl('https://api.testsprite.com', 'p_dryrun_2026', opts.testId) ??
+        `https://www.testsprite.com/dashboard/tests/p_dryrun_2026/test/${encodeURIComponent(opts.testId)}`,
     };
     out.print(sample, data => (data as { dashboardUrl: string }).dashboardUrl);
     return sample;

src/lib/browser.test.ts

@@ -61,10 +61,34 @@ describe('openInBrowser', () => {
 
     it('spawns detached, ignores stdio, and unrefs the child', () => {
       const unref = vi.fn();
-      spawnMock.mockReturnValue({ unref });
+      spawnMock.mockReturnValue({ unref, on: vi.fn() });
       openInBrowser(url, { platform: 'darwin' });
       expect(spawnMock).toHaveBeenCalledWith('open', [url], { detached: true, stdio: 'ignore' });
       expect(unref).toHaveBeenCalledTimes(1);
     });
+
+    it("handles the child's async 'error' (missing binary) with a stderr hint, not a crash", () => {
+      // spawn() reports ENOENT asynchronously on the child; an unhandled
+      // 'error' event would crash the CLI. The default spawner must register
+      // a listener that degrades to the manual-open hint.
+      const listeners = new Map<string, (err: Error) => void>();
+      spawnMock.mockReturnValue({
+        unref: vi.fn(),
+        on: (event: string, listener: (err: Error) => void) => {
+          listeners.set(event, listener);
+        },
+      });
+      const stderrSpy = vi.spyOn(process.stderr, 'write').mockReturnValue(true);
+      try {
+        openInBrowser(url, { platform: 'linux' });
+        const onError = listeners.get('error');
+        expect(onError).toBeDefined();
+        // Firing the listener must not throw and must print the hint.
+        expect(() => onError!(new Error('spawn xdg-open ENOENT'))).not.toThrow();
+        expect(String(stderrSpy.mock.calls.at(-1)?.[0])).toContain('could not launch a browser');
+      } finally {
+        stderrSpy.mockRestore();
+      }
+    });
   });
 });

src/lib/browser.ts

@@ -31,6 +31,15 @@ export function openInBrowser(url: string, deps: OpenInBrowserDeps = {}): void {
     deps.exec ??
     ((command: string, args: readonly string[]) => {
       const child = spawn(command, [...args], { detached: true, stdio: 'ignore' });
+      // spawn() reports a missing binary (ENOENT) ASYNCHRONOUSLY on the child,
+      // so the caller's try/catch cannot see it — and an unhandled 'error'
+      // event would crash the whole CLI. The URL is already on stdout, so
+      // degrade to the same manual-open hint the sync failure path prints.
+      child.on('error', () => {
+        process.stderr.write(
+          'could not launch a browser; open the URL above manually (or use --no-browser)\n',
+        );
+      });
       child.unref();
     });