test: globalSetup build once; drop fileParallelism and per-suite beforeAll builds

Author: SahilRakhaiya05

src/lib/credentials.test.ts

@@ -1,11 +1,10 @@
-import { execSync } from 'node:child_process';
 import type { ChildProcess } from 'node:child_process';
 import { spawn } from 'node:child_process';
 import { mkdtempSync, statSync, readFileSync, writeFileSync, existsSync, mkdirSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 import { fileURLToPath } from 'node:url';
-import { afterEach, beforeAll, beforeEach, describe, expect, it } from 'vitest';
+import { afterEach, beforeEach, describe, expect, it } from 'vitest';
 import {
   DEFAULT_PROFILE,
   assertValidProfileName,
@@ -209,10 +208,6 @@ function spawnCredentialsWriter(profile: string, apiKey: string, path: string):
 }
 
 describe('credentials write lock', () => {
-  beforeAll(() => {
-    execSync('npm run build', { cwd: projectRoot, stdio: 'pipe' });
-  });
-
   it('serializes cross-process writes so concurrent profile updates are not lost', async () => {
     const children = [
       spawnCredentialsWriter('dev', 'sk-dev', credentialsPath),

test/cli.subprocess.test.ts

@@ -32,12 +32,8 @@ let baseUrl: string;
 let tmpHome: string;
 
 beforeAll(async () => {
-  // Always rebuild — `npm run build` is fast and a stale `dist/index.js`
-  // would silently mask ESM/import regressions in this suite. The
-  // existsSync skip we used to do here let `dist` rot under
-  // refactors and gave false-green on `project list` once
-  // already.
-  execFileSync('npm', ['run', 'build'], { cwd: REPO_ROOT, stdio: 'pipe' });
+  // `test/global-setup.mjs` builds dist/ once before workers start (skips when
+  // dist/index.js is newer than src/). CI also pre-builds before npm test.
   server = createServer((req: IncomingMessage, res: ServerResponse) => {
     const url = req.url ?? '/';
     if (url.startsWith('/api/cli/v1/projects/')) {

test/global-setup.mjs

@@ -0,0 +1,32 @@
+import { execSync } from 'node:child_process';
+import { existsSync, readdirSync, statSync } from 'node:fs';
+import { join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const repoRoot = fileURLToPath(new URL('..', import.meta.url));
+const distEntry = join(repoRoot, 'dist', 'index.js');
+const srcDir = join(repoRoot, 'src');
+
+function newestMtimeMs(dir) {
+  let newest = 0;
+  for (const entry of readdirSync(dir, { withFileTypes: true })) {
+    const path = join(dir, entry.name);
+    if (entry.isDirectory()) {
+      newest = Math.max(newest, newestMtimeMs(path));
+    } else if (entry.isFile()) {
+      newest = Math.max(newest, statSync(path).mtimeMs);
+    }
+  }
+  return newest;
+}
+
+function needsBuild() {
+  if (!existsSync(distEntry)) return true;
+  return newestMtimeMs(srcDir) > statSync(distEntry).mtimeMs;
+}
+
+/** Runs once before any test file worker — shared dist/ for subprocess suites. */
+export default async function globalSetup() {
+  if (!needsBuild()) return;
+  execSync('npm run build', { cwd: repoRoot, stdio: 'inherit' });
+}

test/help.snapshot.test.ts

@@ -5,14 +5,14 @@
  *
  * Lives under `test/`
  * (not `src/`) to mirror the existing subprocess test pattern — the
- * snapshot runs the real built binary and therefore needs a build in
- * `beforeAll`, the same way `test/cli.subprocess.test.ts` does.
+ * snapshot runs the real built binary; `test/global-setup.mjs` builds
+ * `dist/` once before any worker starts.
  */
 
 import { execFileSync } from 'node:child_process';
 import { dirname, join, resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
-import { beforeAll, describe, expect, it } from 'vitest';
+import { describe, expect, it } from 'vitest';
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const REPO_ROOT = resolve(__dirname, '..');
@@ -45,10 +45,6 @@ const cases: Array<[string, string[]]> = [
 ];
 
 describe('--help snapshots', () => {
-  beforeAll(() => {
-    execFileSync('npm', ['run', 'build'], { cwd: REPO_ROOT, stdio: 'pipe' });
-  });
-
   for (const [name, args] of cases) {
     it(name, () => {
       const out = execFileSync('node', [BIN_PATH, ...args], {

vitest.config.ts

@@ -4,9 +4,7 @@ export default defineConfig({
   test: {
     include: ['src/**/*.{test,spec}.ts', 'test/**/*.{test,spec}.ts'],
     exclude: ['test/dev-e2e/**', 'test/e2e/**', 'node_modules/**', 'dist/**'],
-    // Subprocess/snapshot suites each run `npm run build` in beforeAll; parallel
-    // file workers can race on dist/ and produce a stale binary (exit 1 vs 5 flakes).
-    fileParallelism: false,
+    globalSetup: ['./test/global-setup.mjs'],
     coverage: {
       provider: 'v8',
       reporter: ['text', 'text-summary', 'json-summary', 'html'],