address gemini agent review feedback

Author: merlinsantiago982-cmd

src/commands/agent.test.ts

@@ -1437,6 +1437,17 @@ describe('runInstall — gemini managed-section: append (GEMINI.md exists, no se
     expect(written).toContain('testsprite test run');
     expect(capture.stdout.join('\n')).toContain('gemini');
     expect(capture.stdout.join('\n')).toContain('section-installed');
+
+    await runInstall(
+      { ...BASE_OPTS, target: ['gemini'], force: false },
+      { cwd: CWD, fs: agentFs, ...deps },
+    );
+
+    const rewritten = store.get(geminiAbs)!;
+    expect(rewritten).toContain('# Project Instructions');
+    expect(rewritten).toContain('Keep existing Gemini CLI notes.');
+    expect(rewritten.split(TARGETS.gemini.managedSection!.begin).length - 1).toBe(1);
+    expect(rewritten.split(TARGETS.gemini.managedSection!.end).length - 1).toBe(1);
   });
 });
 

src/commands/agent.ts

@@ -324,7 +324,7 @@ export interface InstallResult {
   action: InstallAction;
   /**
    * Skill(s) this result covers. Own-file targets produce one result per skill
-   * (`[skill]`); the codex managed-section target produces ONE result whose
+   * (`[skill]`); managed-section targets produce ONE result whose
    * section aggregates every installed skill (`[...skills]`).
    */
   skills: string[];
@@ -540,7 +540,7 @@ export async function runInstall(opts: InstallOptions, deps: AgentDeps = {}): Pr
             `[warn] ${relPath} will be ${wouldBeBytes} bytes after this write — ${managedConfig.loadBudgetLabel ?? `the target agent may not load content beyond its ${managedConfig.loadBudgetBytes} byte budget`}. Trim ${relPath} to stay within the limit.`,
           );
         }
-        dryRunLines.push({ abs, bytes, note: 'managed section' });
+        dryRunLines.push({ abs, bytes: wouldBeBytes, note: 'managed section' });
         results.push({ target: t, path: relPath, action: 'dry-run', skills: [...skills] });
         continue;
       }
@@ -762,9 +762,9 @@ export async function runList(opts: CommonOptions, deps: AgentDeps = {}): Promis
   const out = makeOutput(opts.output, deps);
 
   // One row per (target × default skill). Own-file targets land each skill at a
-  // distinct path; the codex managed-section target merges all skills into the
-  // single AGENTS.md (so every codex row shares that path — truthful, since both
-  // skills' content lands there).
+  // distinct path; managed-section targets merge all skills into a single root
+  // instruction file (so every managed-section row shares that path — truthful,
+  // since both skills' content lands there).
   const results: ListResult[] = [];
   for (const [t, spec] of Object.entries(TARGETS) as [
     AgentTarget,

src/lib/agent-targets.test.ts

@@ -713,4 +713,11 @@ describe('content integrity — gemini target (GEMINI.md managed-section body)',
     expect(result.content).not.toContain('name: testsprite-verify');
     expect(result.content).not.toContain('alwaysApply:');
   });
+
+  it('renderForTarget("gemini") supports the onboard managed-section contribution', () => {
+    const result = renderForTarget('gemini', 'testsprite-onboard');
+    expect(result.path).toBe('GEMINI.md');
+    expect(result.content).toBe(ONBOARD_CODEX_LINE);
+    expect(result.content).not.toContain('---');
+  });
 });

src/lib/agent-targets.ts

@@ -136,8 +136,9 @@ function wrapMdc(_name: string, description: string, body: string): string {
 /**
  * Repo-relative landing path for a given skill on a given target (POSIX
  * separators). Own-file targets embed the skill name in the path so multiple
- * skills coexist; the codex target always lands at the single shared `AGENTS.md`
- * (every skill's codex contribution is merged into one managed section there).
+ * skills coexist; managed-section targets land at shared root instruction files
+ * (`AGENTS.md` for codex, `GEMINI.md` for gemini), where every selected skill's
+ * contribution is merged into one managed section.
  */
 export function pathFor(target: AgentTarget, skill: string): string {
   switch (target) {

test/e2e/agent-install.e2e.test.ts

@@ -334,7 +334,7 @@ describe('force overwrite with backup', () => {
     expect(parsed[0]!.action).toBe('updated');
 
     // File must now equal canonical content
-    const { content: canonical } = renderForTarget('claude');
+    const { content: canonical } = renderForTarget('claude', 'testsprite-verify');
     expect(readFileSync(filePath, 'utf8')).toBe(canonical);
 
     // .bak must hold the edited bytes