fix(browser): map non-http(s) URL rejection to exit 5 (validation error)

openInBrowser threw a plain Error for a non-http(s) URL, which fell through the top-level handler and exited 1. Route it through localValidationError so it is classified as VALIDATION_ERROR and maps to the documented exit code 5, matching every other bad-argument path. Test asserts the exit code, not the message string.

Author: Andy00L

src/lib/browser.test.ts

@@ -9,6 +9,7 @@ vi.mock('node:child_process', () => ({
 }));
 
 import { openInBrowser } from './browser.js';
+import { ApiError } from './errors.js';
 
 describe('openInBrowser', () => {
   const url = 'https://portal.example.com/tests/t_123';
@@ -40,11 +41,16 @@ describe('openInBrowser', () => {
     expect(calls).toEqual([{ command: 'xdg-open', args: [url] }]);
   });
 
-  it('refuses a non-http(s) URL before spawning', () => {
+  it('refuses a non-http(s) URL with exit 5 before spawning', () => {
     const exec = vi.fn();
-    expect(() => openInBrowser('file:///etc/passwd', { platform: 'linux', exec })).toThrow(
-      /non-http\(s\)/,
-    );
+    let error: unknown;
+    try {
+      openInBrowser('file:///etc/passwd', { platform: 'linux', exec });
+    } catch (err) {
+      error = err;
+    }
+    expect(error).toBeInstanceOf(ApiError);
+    expect((error as ApiError).exitCode).toBe(5);
     expect(exec).not.toHaveBeenCalled();
   });
 

src/lib/browser.ts

@@ -14,6 +14,7 @@
  * are the caller's to surface (it already printed the URL as the fallback).
  */
 import { spawn } from 'node:child_process';
+import { localValidationError } from './errors.js';
 
 export interface OpenInBrowserDeps {
   platform?: NodeJS.Platform;
@@ -24,7 +25,14 @@ export interface OpenInBrowserDeps {
 export function openInBrowser(url: string, deps: OpenInBrowserDeps = {}): void {
   const parsed = new URL(url);
   if (parsed.protocol !== 'https:' && parsed.protocol !== 'http:') {
-    throw new Error(`refusing to open a non-http(s) URL (${parsed.protocol})`);
+    // User-input error, not an internal failure: classify as VALIDATION_ERROR
+    // so it maps to exit 5 (like every other bad-argument path), not exit 1.
+    throw localValidationError(
+      'url',
+      `must be an http(s) URL (got ${parsed.protocol})`,
+      undefined,
+      'field',
+    );
   }
   const platform = deps.platform ?? process.platform;
   const exec =