test: make credential writer race deterministic

Author: naufalfx805-source

test/credentials-cross-process.test.ts

@@ -49,6 +49,19 @@ function runCredentialWriter(env: Record<string, string>): Promise<ChildResult>
   });
 }
 
+async function waitForFiles(paths: string[], timeoutMs = 5_000): Promise<void> {
+  const deadline = Date.now() + timeoutMs;
+
+  while (true) {
+    const missing = paths.filter(path => !existsSync(path));
+    if (missing.length === 0) return;
+    if (Date.now() >= deadline) {
+      throw new Error(`Timed out waiting for files: ${missing.join(', ')}`);
+    }
+    await new Promise(resolveDelay => setTimeout(resolveDelay, 5));
+  }
+}
+
 describe('credentials cross-process writes', () => {
   beforeAll(() => {
     execNpm(['run', 'build'], { cwd: REPO_ROOT, stdio: 'pipe' });
@@ -81,7 +94,9 @@ describe('credentials cross-process writes', () => {
         CRED_API_KEY: 'sk-child-timeout',
         CRED_PATH: join(tmpRoot, 'credentials'),
         CRED_PROFILE: 'child-timeout',
+        CRED_POLL_MS: '1',
         CRED_START_PATH: startPath,
+        CRED_START_TIMEOUT_MS: '100',
       });
 
       expect(result).toMatchObject({
@@ -130,16 +145,18 @@ describe('credentials cross-process writes', () => {
         apiKey: `sk-child-${index}`,
         profile: `child-${index}`,
       }));
-      const children = profiles.map(({ apiKey, profile }) =>
+      const readyPaths = profiles.map(({ profile }) => join(tmpRoot, `${profile}.ready`));
+      const children = profiles.map(({ apiKey, profile }, index) =>
         runCredentialWriter({
           CRED_API_KEY: apiKey,
           CRED_PATH: credentialsPath,
           CRED_PROFILE: profile,
+          CRED_READY_PATH: readyPaths[index]!,
           CRED_START_PATH: startPath,
         }),
       );
 
-      await new Promise(resolveDelay => setTimeout(resolveDelay, 50));
+      await waitForFiles(readyPaths);
       writeFileSync(startPath, 'go');
 
       const results = await Promise.all(children);

test/helpers/credentials-write-child.mjs

@@ -1,23 +1,40 @@
-import { existsSync } from 'node:fs';
+import { existsSync, writeFileSync } from 'node:fs';
 import { writeProfile } from '../../dist/lib/credentials.js';
 
 const profile = process.env.CRED_PROFILE;
 const credentialsPath = process.env.CRED_PATH;
 const apiKey = process.env.CRED_API_KEY;
 const startPath = process.env.CRED_START_PATH;
+const readyPath = process.env.CRED_READY_PATH;
+const startTimeoutMs = Number(process.env.CRED_START_TIMEOUT_MS ?? '5000');
+const pollMs = Number(process.env.CRED_POLL_MS ?? '5');
 
 if (!profile || !credentialsPath || !apiKey || !startPath) {
   console.error('CRED_PROFILE, CRED_PATH, CRED_API_KEY, and CRED_START_PATH are required');
   process.exit(1);
 }
 
-const deadline = Date.now() + 5_000;
+if (
+  !Number.isInteger(startTimeoutMs) ||
+  startTimeoutMs < 1 ||
+  !Number.isInteger(pollMs) ||
+  pollMs < 1
+) {
+  console.error('CRED_START_TIMEOUT_MS and CRED_POLL_MS must be positive integers');
+  process.exit(1);
+}
+
+if (readyPath) {
+  writeFileSync(readyPath, 'ready');
+}
+
+const deadline = Date.now() + startTimeoutMs;
 while (!existsSync(startPath)) {
   if (Date.now() >= deadline) {
     console.error(`Timed out waiting for start marker: ${startPath}`);
     process.exit(2);
   }
-  Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 5);
+  Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, pollMs);
 }
 
 try {