Skip to content

Commit 09c1c75

Browse files
authored
Add tooltips and accessible labels for all site icons (#902)
* Initial plan * Add tooltip and accessible text to all icons * Avoid duplicate screen reader labels on footer icons * Hide decorative linked icons from screen readers * Mark decorative 404 home icon as aria-hidden --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
1 parent 91b48f5 commit 09c1c75

4 files changed

Lines changed: 10 additions & 11 deletions

File tree

404.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,10 @@ <h1>Oops! Page not found</h1>
1313
</div>
1414
<div class="error-actions" style="text-align: center;">
1515
<p><img src="https://octodex.github.com/images/scubatocat.png" alt="Octocat" width="300" height="300"></p>
16-
<a href="/" class="btn btn-primary btn-lg"><span class="fa fa-home"></span>
16+
<a href="/" class="btn btn-primary btn-lg"><span class="fa fa-home" aria-hidden="true" title="Home"></span>
1717
Take Me Home </a>
1818
</div>
1919
</div>
2020
</div>
2121
</div>
2222
</div>
23-

_includes/footer.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@
3131
</div>
3232
<div class="footer-social-icons">
3333
<a href="https://testingconferences.us11.list-manage.com/subscribe?u=2a811daec24cc97909dfdf01d&id=88f87313fc" target="_blank" rel="noopener noreferrer" aria-label="Subscribe to Newsletter" title="Subscribe to Newsletter">
34-
<i class="fa-solid fa-envelope fa-2x"></i>
34+
<i class="fa-solid fa-envelope fa-2x" aria-hidden="true"></i>
3535
</a>
3636
<a href="https://github.com/TestingConferences/testingconferences.github.io" target="_blank" rel="noopener noreferrer" aria-label="GitHub" title="GitHub">
37-
<i class="fa-brands fa-github fa-2x"></i>
37+
<i class="fa-brands fa-github fa-2x" aria-hidden="true"></i>
3838
</a>
3939
<a href="https://x.com/testconferences" target="_blank" rel="noopener noreferrer" aria-label="X (Twitter)" title="X (Twitter)">
40-
<i class="fa-brands fa-x-twitter fa-2x"></i>
40+
<i class="fa-brands fa-x-twitter fa-2x" aria-hidden="true"></i>
4141
</a>
4242
</div>
4343
<div name="copyright" class="footer-col-wrapper">

index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
<li>
99
<h2><a href="{{current.url}}">{{ current.name }}</a></h2>
1010
<p>
11-
<i class="fa fa-calendar"></i> {{ current.dates }}
12-
<i class="fa fa-map-marker"></i> {{ current.location }}
13-
{% if current.status != nil %}<i class="fa fa-bell"></i> {{current.status}}{% endif %}
11+
<i class="fa fa-calendar" role="img" aria-label="Dates" title="Dates"></i> {{ current.dates }}
12+
<i class="fa fa-map-marker" role="img" aria-label="Location" title="Location"></i> {{ current.location }}
13+
{% if current.status != nil %}<i class="fa fa-bell" role="img" aria-label="Status" title="Status"></i> {{current.status}}{% endif %}
1414
</li>
1515
{% endfor %}
1616
</ul>

past.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
<li>
1010
<h2><a href="{{past.url}}">{{ past.name }}</a></h2>
1111
<p>
12-
<i class="fa fa-calendar"></i> {{ past.dates }} <i class="fa fa-map-marker"></i> {{ past.location }}
12+
<i class="fa fa-calendar" role="img" aria-label="Dates" title="Dates"></i> {{ past.dates }} <i class="fa fa-map-marker" role="img" aria-label="Location" title="Location"></i> {{ past.location }}
1313
{% if past.twitter != nil %}<a href="https://www.twitter.com/{{past.twitter}}"><i
14-
class="fa-brands fa-x-twitter"></i>{{past.twitter}}</a>{% endif %}
15-
{% if past.video_url != nil %}<a href="{{ past.video_url }}"><i class="fa fa-video-camera"></i> Event
14+
class="fa-brands fa-x-twitter" aria-hidden="true" title="X (Twitter)"></i>{{past.twitter}}</a>{% endif %}
15+
{% if past.video_url != nil %}<a href="{{ past.video_url }}"><i class="fa fa-video-camera" aria-hidden="true" title="Event videos"></i> Event
1616
Videos</a>{% endif %}
1717
</li>
1818
{% endfor %}

0 commit comments

Comments
 (0)