DURACLOUD-1102: updates createSpace method to check for existence of space before try… (duracloud#195)

* udpates createSpace method to check for existence of space before trying to create it

* fixes testCreateSpace()

Author: nwoodward

storeclient/src/main/java/org/duracloud/client/ContentStoreImpl.java

@@ -400,8 +400,13 @@ public void createSpace(final String spaceId)
         execute(new Retriable() {
             @Override
             public Boolean retry() throws ContentStoreException {
-                // The actual method being executed
-                doCreateSpace(spaceId);
+                // First check if space exists
+                try {
+                    getSpace(spaceId, null, 0, null);
+                } catch (NotFoundException e) {
+                    // Try creating the space if it doesn't exist
+                    doCreateSpace(spaceId);
+                }
                 return true;
             }
         });

storeclient/src/test/java/org/duracloud/client/ContentStoreImplTest.java

@@ -75,14 +75,16 @@ public class ContentStoreImplTest {
     private String spaceId = "myspace";
     private String contentId = "mycontent";
 
+    private int maxRetries = 3;
+
     @Before
     public void setUp() throws Exception {
         restHelper = EasyMock.createMock("RestHttpHelper",
                                          RestHttpHelper.class);
         response = EasyMock.createMock("HttpResponse",
                                        RestHttpHelper.HttpResponse.class);
 
-        contentStore = new ContentStoreImpl(baseURL, type, storeId, false, restHelper);
+        contentStore = new ContentStoreImpl(baseURL, type, storeId, false, restHelper, maxRetries);
     }
 
     @After
@@ -228,9 +230,17 @@ public void testGetAuditLog() throws Exception {
 
     @Test
     public void testCreateSpace() throws Exception {
-        String fullURL = baseURL + "/" + spaceId + "?storeID=" + storeId;
+        // First call is to check if space exists
+        String existsFullURL = baseURL + "/" + spaceId +
+                "?storeID=" + storeId;
+        EasyMock.expect(response.getStatusCode()).andReturn(404).times(4);
+        EasyMock.expect(response.getResponseBody()).andReturn("").times(4);
+        EasyMock.expect(restHelper.get(existsFullURL)).andReturn(response).times(4);
+
+        // Second call is to create space
+        String createFullURL = baseURL + "/" + spaceId + "?storeID=" + storeId;
         EasyMock.expect(response.getStatusCode()).andReturn(201);
-        EasyMock.expect(restHelper.put(fullURL, null, null)).andReturn(response);
+        EasyMock.expect(restHelper.put(createFullURL, null, null)).andReturn(response);
 
         replayMocks();