Skip to content

Commit be83fc6

Browse files
author
pranav_a
committed
minor fixes
1 parent e3a5700 commit be83fc6

3 files changed

Lines changed: 8 additions & 17 deletions

File tree

skills/tinyml-agentic-skill/references/skill_setup_guide.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@ If `success: false`, show the user the `errors` and `hint` fields and ask them t
3030
**Setup repo and environment for working**
3131

3232
Once the repository is installed and the installation is verified, also verify if the repository has been set-up with a virtual environment and is ready for use.
33-
First check to find a virtual environment which may be present at the root level of the tinyml-tensorlab repository (installed at `$TINYML_BASE_PATH`).
34-
Try `source .venv/bin/activate` or `source venv/bin/activate`.
35-
Then try running the following script:
33+
34+
Try running the following script:
3635
```python
3736

3837
import tinyml_modelmaker
@@ -99,4 +98,6 @@ ls $TINYML_TENSORLAB_DOCS_PATH/getting_started/ 2>/dev/null | head -3
9998
```
10099
If this returns no output or an error, the path is wrong. Correct value is `$TINYML_BASE_PATH/docs/source/`. Fix it before writing to `.env`.
101100

102-
**ALWAYS CREATE A LOCAL `.env` FILE WITH ALL OF THE ABOVE 4 ENV VARIABLES**
101+
**ALWAYS CREATE A LOCAL `.env` FILE WITH ALL OF THE ABOVE 4 ENV VARIABLES**
102+
103+
After the `tinyml-tensorlab` repository is fully set up, index the repository and ensure you understand it fully. You must be able to retrieve relevant context whenever necessary going forward.

skills/tinyml-agentic-skill/scripts/dataset_format_tools.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,6 @@ def _check_regression(path: str, is_zip: bool) -> Tuple[List[str], List[str], bo
519519
warnings.append(
520520
"No annotations/ directory found. "
521521
"ModelMaker will auto-generate train/val splits using split_factor from config. "
522-
"Call reorganize_dataset to generate annotation files explicitly."
523522
)
524523
else:
525524
if not os.path.exists(os.path.join(ann_dir, "instances_train_list.txt")):
@@ -541,9 +540,7 @@ def validate_dataset_format(
541540
format for the given task_type.
542541
543542
Call this tool immediately after the user provides input_data_path, BEFORE
544-
generating the dataset config section. If validation fails (is_valid=False),
545-
call reorganize_dataset to fix the layout, then continue with config generation
546-
using the new_input_data_path returned by reorganize_dataset.
543+
generating the dataset config section.
547544
548545
Supported input: local directory path or local .zip file.
549546
Remote URLs cannot be validated — skip validation and proceed with config generation.
@@ -562,7 +559,6 @@ def validate_dataset_format(
562559
— ALWAYS show this to the user when validation fails
563560
- issues: list of errors blocking correct data loading
564561
- warnings: list of non-fatal issues (ModelMaker may still work)
565-
- can_auto_reorganize: True if reorganize_dataset can fix all issues automatically
566562
- reorganize_hints: instructions for the user if can_auto_reorganize is False
567563
(e.g., which parameters to provide to reorganize_dataset)
568564
- success: True if the validation check itself completed without internal errors
@@ -574,7 +570,6 @@ def validate_dataset_format(
574570
"expected_structure": _EXPECTED_STRUCTURES[_get_task_family(task_type)],
575571
"issues": [],
576572
"warnings": ["Remote URL provided — format validation skipped. Ensure dataset matches expected structure."],
577-
"can_auto_reorganize": False,
578573
"reorganize_hints": "Download the dataset locally to run format validation.",
579574
"success": True,
580575
}
@@ -586,7 +581,6 @@ def validate_dataset_format(
586581
"expected_structure": _EXPECTED_STRUCTURES[_get_task_family(task_type)],
587582
"issues": [f"Path does not exist: {input_data_path}"],
588583
"warnings": [],
589-
"can_auto_reorganize": False,
590584
"reorganize_hints": "Verify the path and try again.",
591585
"success": True,
592586
}
@@ -608,7 +602,6 @@ def validate_dataset_format(
608602
"expected_structure": _EXPECTED_STRUCTURES[family],
609603
"issues": [f"Validation failed with internal error: {e}"],
610604
"warnings": [],
611-
"can_auto_reorganize": False,
612605
"reorganize_hints": "",
613606
"success": False,
614607
}
@@ -619,7 +612,6 @@ def validate_dataset_format(
619612
"expected_structure": _EXPECTED_STRUCTURES[family],
620613
"issues": errors,
621614
"warnings": warnings,
622-
"can_auto_reorganize": can_fix if errors else True,
623615
"reorganize_hints": hints if errors else "",
624616
"success": True,
625617
}

skills/tinyml-agentic-skill/scripts/dataset_section_tools.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,8 @@ def validate_dataset_section(
156156
"effective_input_data_path": None,
157157
"format_validation": format_validation,
158158
"errors": [
159-
"Dataset format is incorrect. "
160-
"Show the user the expected_structure and issues from format_validation, "
161-
"then gather the required parameters described in reorganize_hints and "
162-
"call reorganize_dataset_stage_1."
159+
"Dataset format is incorrect."
160+
"Show the user the expected_structure and issues from format_validation."
163161
],
164162
"warnings": [],
165163
}

0 commit comments

Comments
 (0)