fix(log): add missing scroll_end to write_line#5672
Merged
willmcgugan merged 2 commits intoTextualize:mainfrom Mar 25, 2025
Merged
fix(log): add missing scroll_end to write_line#5672willmcgugan merged 2 commits intoTextualize:mainfrom
willmcgugan merged 2 commits intoTextualize:mainfrom
Conversation
Add `scroll_end` parameter to the `Rich.write_line` method. The other write methods have this parameter, but must have been just overlooked for `write_line`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
scroll_endparameter to theLog.write_linemethod. The other write methods have this parameter, but must have been just overlooked forwrite_line.Please review the following checklist.