fix: resolve type error and clean up duplicate code in og route

Author: Kokila-chandrakar

app/api/og/route.tsx

@@ -21,7 +21,6 @@ const displayDomain = (() => {
 
 function getLuminance(hex: string) {
   let normalizedHex = hex.trim();
-  // Normalize short hex (e.g., #fff or #ffff) to #rrggbb (alpha is ignored for luminance)
   if (normalizedHex.length === 4 || normalizedHex.length === 5) {
     normalizedHex = `#${normalizedHex[1]}${normalizedHex[1]}${normalizedHex[2]}${normalizedHex[2]}${normalizedHex[3]}${normalizedHex[3]}`;
   }
@@ -37,9 +36,6 @@ function getLuminance(hex: string) {
 
 export async function GET(req: NextRequest) {
   const { searchParams } = new URL(req.url);
-  const parsed = ogParamsSchema.parse(Object.fromEntries(searchParams.entries()));
-  let { user } = parsed;
-  const { theme, bg, text, accent } = parsed;
 
   const parseResult = ogParamsSchema.safeParse(Object.fromEntries(searchParams.entries()));
 
@@ -54,8 +50,6 @@ export async function GET(req: NextRequest) {
   }
 
   const { user, theme, bg, text, accent, refresh } = parseResult.data;
-  // Sanitize user: limit to 39 chars (GitHub max length) and strip invalid chars
-  user = user.slice(0, 39).replace(/[^a-zA-Z0-9-]/g, '');
 
   const selectedTheme = themes[theme] || themes.dark;
   const resolvedBg = `#${bg || selectedTheme.bg}`;
@@ -72,18 +66,17 @@ export async function GET(req: NextRequest) {
   let longestStreak = 0;
   let currentStreak = 0;
 
-  // Only the data fetching is wrapped in try/catch — not the JSX rendering.
   try {
-    const calendar = await fetchGitHubContributions(user, { bypassCache: refresh });
-    const userData = await fetchGitHubContributions(user, { bypassCache: true });
-    const calendar = userData.calendar;
-    const stats = calculateStreak(calendar);
+    // bypassCache mirrors the ?refresh=true pattern used by /api/stats and /api/streak.
+    // Without this, every link-preview bot crawl fires a fresh GitHub GraphQL request,
+    // burning API quota on an endpoint that is embedded in every page's <meta> tag.
+    const data = await fetchGitHubContributions(user, { bypassCache: refresh });
+    const stats = calculateStreak(data.calendar ?? data);
     totalCommits = stats.totalContributions;
     longestStreak = stats.longestStreak;
     currentStreak = stats.currentStreak;
   } catch (err) {
     console.error('[OG] stats fetch failed:', err);
-    // fallback to zeros if GitHub is unreachable
   }
 
   const cacheControl = refresh
@@ -130,7 +123,6 @@ export async function GET(req: NextRequest) {
         {`@${user}`}
       </div>
       <div style={{ display: 'flex', gap: '48px' }}>
-        {/* Total Commits */}
         <div
           style={{
             display: 'flex',
@@ -151,7 +143,6 @@ export async function GET(req: NextRequest) {
             Total Commits
           </div>
         </div>
-        {/* Longest Streak */}
         <div
           style={{
             display: 'flex',
@@ -172,7 +163,6 @@ export async function GET(req: NextRequest) {
             {'Longest Streak 🔥'}
           </div>
         </div>
-        {/* Current Streak */}
         <div
           style={{
             display: 'flex',