Fix code review issues: separate curl multi options, fix URI in exception, remove error_log

Co-authored-by: Thavarshan <10804999+Thavarshan@users.noreply.github.com>

Author: Copilot

src/Fetch/Pool/DnsCache.php

@@ -179,7 +179,7 @@ protected function performDnsLookup(string $hostname): array
         if (empty($addresses)) {
             throw new NetworkException(
                 "Failed to resolve hostname: {$hostname}",
-                new \GuzzleHttp\Psr7\Request('GET', $hostname)
+                new \GuzzleHttp\Psr7\Request('GET', "https://{$hostname}/")
             );
         }
 

src/Fetch/Pool/HostConnectionPool.php

@@ -169,9 +169,8 @@ protected function warmupConnections(): void
                 $connection = $this->createConnection();
                 $connection->decrementActiveRequests(); // Was incremented in createConnection
                 $this->availableConnections->enqueue($connection);
-            } catch (\Throwable $e) {
-                // Log warmup failure but continue
-                error_log('Connection warmup failed: '.$e->getMessage());
+            } catch (\Throwable) {
+                // Warmup failure is not critical - stop warming up but continue
                 break;
             }
         }

src/Fetch/Pool/Http2Configuration.php

@@ -119,13 +119,26 @@ public function getCurlOptions(): array
         $options = [];
 
         if ($this->enabled) {
-            // Use HTTP/2
+            // Use HTTP/2 with automatic fallback
             $options[CURLOPT_HTTP_VERSION] = CURL_HTTP_VERSION_2_0;
+        }
+
+        return $options;
+    }
+
+    /**
+     * Get cURL multi options for HTTP/2 multiplexing.
+     *
+     * These options should be used with curl_multi_setopt().
+     *
+     * @return array<int, mixed>
+     */
+    public function getCurlMultiOptions(): array
+    {
+        $options = [];
 
-            // Enable multiplexing
-            if (defined('CURLPIPE_MULTIPLEX')) {
-                $options[CURLMOPT_PIPELINING] = CURLPIPE_MULTIPLEX;
-            }
+        if ($this->enabled && defined('CURLPIPE_MULTIPLEX')) {
+            $options[CURLMOPT_PIPELINING] = CURLPIPE_MULTIPLEX;
         }
 
         return $options;

tests/Unit/ConnectionPoolTest.php

@@ -295,6 +295,18 @@ public function test_http2_curl_options(): void
         $this->assertEquals(CURL_HTTP_VERSION_2_0, $curlOptions[CURLOPT_HTTP_VERSION]);
     }
 
+    public function test_http2_curl_multi_options(): void
+    {
+        $config = new Http2Configuration(enabled: true);
+        $curlMultiOptions = $config->getCurlMultiOptions();
+
+        // CURLMOPT_PIPELINING should be in multi options, not regular curl options
+        if (defined('CURLPIPE_MULTIPLEX')) {
+            $this->assertArrayHasKey(CURLMOPT_PIPELINING, $curlMultiOptions);
+            $this->assertEquals(CURLPIPE_MULTIPLEX, $curlMultiOptions[CURLMOPT_PIPELINING]);
+        }
+    }
+
     public function test_http2_disabled_curl_options(): void
     {
         $config = new Http2Configuration(enabled: false);