Integration test test_sql_context_filters_catalog_and_preserves_rank fails with ACL dependency object

[doctorjia]

Environment

• OS: macOS (Darwin) [github](https://github.com/The-AI-Framework-and-Data-Tech-Lab-HK/ContextHub/blob/main/docs/setup/local-setup&end2end-verification-guide-zh.md)
• Python: 3.12.6
• pytest: 9.0.3
• Repo: The-AI-Framework-and-Data-Tech-Lab-HK/ContextHub (main) [github](https://github.com/The-AI-Framework-and-Data-Tech-Lab-HK/ContextHub/blob/main/docs/setup/local-setup&end2end-verification-guide-zh.md)
• Command run (step 7b of local setup guide): [github](https://github.com/The-AI-Framework-and-Data-Tech-Lab-HK/ContextHub/blob/main/docs/setup/local-setup&end2end-verification-guide-zh.md)

CONTEXTHUB_INTEGRATION=1 pytest \
  tests/test_integration_propagation.py \
  tests/test_integration_collaboration.py \
  tests/test_integration_visibility.py \
  tests/test_datalake.py \
  -v

Observed behavior

Out of 39 tests, 38 pass and 1 fails: tests/test_datalake.py::test_sql_context_filters_catalog_and_preserves_rank.

Relevant failure trace:

E   AttributeError: 'Depends' object has no attribute 'check_read_access'

This happens inside search_sql_context in src/contexthub/api/routers/datalake.py when calling:

decision = await acl.check_read_access(db, uri, ctx)

From the test, search_sql_context is invoked directly with:

resp = await search_sql_context(
    SqlContextRequest(query="orders by user", catalog="mock", top_k=2),
    ctx=query_agent_ctx,
    db=acme_session,
    retrieval=_StubRetrieval(),
)

Since the test does not provide acl and masking, the default FastAPI Depends(...) objects are used instead of real ACLService / MaskingService instances, leading to the AttributeError.

Expected behavior

Given the 7b description in the setup guide, running the database integration tests with CONTEXTHUB_INTEGRATION=1 should result in all tests passing. [github](https://github.com/The-AI-Framework-and-Data-Tech-Lab-HK/ContextHub/blob/main/docs/setup/local-setup&end2end-verification-guide-zh.md)

Steps to reproduce

1. Follow docs/setup/local-setup&end2end-verification-guide-zh.md to: [github](https://github.com/The-AI-Framework-and-Data-Tech-Lab-HK/ContextHub/blob/main/docs/setup/local-setup&end2end-verification-guide-zh.md)

   • Install PostgreSQL + pgvector
   • Create contexthub database and user
   • Set up Python venv and install dependencies (pip install -e ".[dev]", pip install greenlet, etc.)
   • Run migrations (alembic upgrade head)
   • Ensure PostgreSQL is running and health checks pass

2. From repo root, in the activated venv, run: [github](https://github.com/The-AI-Framework-and-Data-Tech-Lab-HK/ContextHub/blob/main/docs/setup/local-setup&end2end-verification-guide-zh.md)

   CONTEXTHUB_INTEGRATION=1 pytest \
     tests/test_integration_propagation.py \
     tests/test_integration_collaboration.py \
     tests/test_integration_visibility.py \
     tests/test_datalake.py \
     -v

3. Observe that only tests/test_datalake.py::test_sql_context_filters_catalog_and_preserves_rank fails with AttributeError: 'Depends' object has no attribute 'check_read_access'.

[heathersherry]

Thanks for reporting this, @doctorjia!

This issue was actually already fixed in commit 5b68181 ("fix test cases", Apr 10) — three days before this issue was filed. The fix adds an _AllowAllACL stub and explicitly passes acl and masking to the direct search_sql_context() call in the test:

+    class _AllowAllACL:
+        async def check_read_access(self, db, uri, ctx):
+            return AccessDecision(allowed=True, field_masks=None, reason="ok")
+
     resp = await search_sql_context(
         SqlContextRequest(query="orders by user", catalog="mock", top_k=2),
         ctx=query_agent_ctx,
         db=acme_session,
         retrieval=_StubRetrieval(),
+        acl=_AllowAllACL(),
+        masking=MaskingService(),
     )

Root cause: search_sql_context is a FastAPI route handler whose acl and masking parameters default to Depends(...). When called directly (not through FastAPI's dependency injection), those defaults remain as raw Depends wrapper objects rather than resolved service instances — hence the AttributeError.

Resolution: Please pull the latest main branch and re-run the tests:

git pull origin main
CONTEXTHUB_INTEGRATION=1 pytest tests/test_datalake.py::test_sql_context_filters_catalog_and_preserves_rank -v

All 39 tests should now pass.