Skip to content

Commit 5b227ae

Browse files
committed
docs(claude): final pass complete — update audit log
https://claude.ai/code/session_01A9Xk6PLY19MqFCQBMkdmQ7
1 parent fa731b3 commit 5b227ae

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ There are two completely separate JSON files that could be confused.
238238
- **print() → Logger migration complete** (2026-05-31): All `print()` calls in the main app target, AltStoreCore, AltWidget, and SideStore/Utils/ have been replaced with `Logger.main.*`. Remaining prints are in: `SideStore/MinimuxerWrapper.swift` (30+ bridge traces, separate refactor task), `Shared/` (no AltStoreCore dep — use OSLog directly if needed), `AltBackup/` (separate companion app target), and `SideStore/Tests/` (test files — intentional).
239239
- **Dead code + incorrect pattern cleanup complete** (2026-05-31): All Settings VCs use cross-dissolve animation for OLED/accent reloadData. Retain cycles in `AdvancedSettingsViewController` UIAlertAction closures fixed. Expiry notification cancel bug fixed (prefix-filter instead of wrong single ID). All 5 experimental features confirmed fully wired into production code.
240240
- **RSTAsyncBlockOperation `operation.finish()` audit complete** (2026-06-03): Systemic missing `finish()` on success/failure paths in all prefetch handlers. Fixed in: `BrowseViewController`, `NewsViewController`, `SourcesViewController`, `SourceDetailContentViewController`, `AddSourceViewController` (×2), `AppCardCollectionViewCell`, `AppScreenshotsViewController`, `PreviewAppScreenshotsViewController`, `ErrorLogViewController` (×4 paths including nil-context guard). All operations in `MyAppsViewController` and `AppManager` already called `finish()` correctly.
241-
- **Extended bug audit complete** (2026-06-03): `Date+RelativeDate` formatted `date` (now) instead of `self` — all news items older than 1 day showed today's date. `AppPermission17To17_1MigrationPolicy` left `_permission` nil for unknown type strings — added empty-string sentinel. `OperationError.maximumAppIDLimitReached` force-unwrapped `DateComponentsFormatter.string(from:)` which returns nil when expiry is past. `UIColor+Hex` `scanInt32` overflowed on ARGB values with alpha ≥ 0x80. `ProcessInfo+AltStore` `BuildVersion.<` nil-suffix comparison inverted (GM sorted before beta). `super.init()` missing in `BackupController` and `ActiveAppsTimelineProvider`. CI build failure (Unicode curly quotes in `ReviewPermissionsViewController`) fixed.
241+
- **Extended bug audit complete** (2026-06-03): `AppPermission17To17_1MigrationPolicy` left `_permission` nil for unknown type strings — added empty-string sentinel. `StoreApp11To17_1` and `StoreApp17To17_1` migration policies passed untyped `Any?` values directly to non-optional `@NSManaged String` properties — added `as? String ?? ""` coercion. `OperationError.maximumAppIDLimitReached` force-unwrapped `DateComponentsFormatter.string(from:)` which returns nil when expiry is past. `UIColor+Hex` `scanInt32` overflowed on ARGB values with alpha ≥ 0x80. `ProcessInfo+AltStore` `BuildVersion.<` nil-suffix comparison inverted (GM sorted before beta). `super.init()` missing in `BackupController` and `ActiveAppsTimelineProvider`. CI build failure (Unicode curly quotes in `ReviewPermissionsViewController`) fixed. `AltWidget/AppsTimelineProvider` `allSatisfy` condition inverted — healthy widgets got relevance 0. `Countdown.swift` `numberOfDays < 0` dead code — capsule shape never shown for expired apps. `ChangelogViewController` `UIHostingConfiguration` retain cycle — broke by capturing `isLoadingMore` as a local value.
242242

243243
### Remaining `print()` targets (future work)
244244

0 commit comments

Comments
 (0)