Core/Misc: fixed several unused variable warnings

Author: Ovahlord

src/common/Logging/Log.cpp

@@ -112,7 +112,6 @@ void Log::CreateLoggerFromConfig(std::string const& appenderName)
         return;
 
     LogLevel level = LOG_LEVEL_DISABLED;
-    uint8 type = uint8(-1);
 
     std::string options = sConfigMgr->GetStringDefault(appenderName, "");
     std::string name = appenderName.substr(7);

src/server/game/Server/WorldSession.cpp

@@ -108,7 +108,7 @@ bool WorldSessionFilter::Process(WorldPacket* packet)
 }
 
 /// WorldSession constructor
-WorldSession::WorldSession(uint32 id, std::string&& name, uint32 battlenetAccountId, std::shared_ptr<WorldSocket> sock, AccountTypes sec, uint8 expansion, time_t mute_time, LocaleConstant locale, uint32 recruiter, bool isARecruiter) :
+WorldSession::WorldSession(uint32 id, std::string&& name, std::shared_ptr<WorldSocket> sock, AccountTypes sec, uint8 expansion, time_t mute_time, LocaleConstant locale, uint32 recruiter, bool isARecruiter) :
     m_muteTime(mute_time),
     m_timeOutTime(0),
     AntiDOS(this),

src/server/game/Server/WorldSession.h

@@ -475,7 +475,7 @@ struct PacketCounter
 class TC_GAME_API WorldSession
 {
     public:
-        WorldSession(uint32 id, std::string&& name, uint32 battlenetAccountId, std::shared_ptr<WorldSocket> sock, AccountTypes sec, uint8 expansion, time_t mute_time, LocaleConstant locale, uint32 recruiter, bool isARecruiter);
+        WorldSession(uint32 id, std::string&& name, std::shared_ptr<WorldSocket> sock, AccountTypes sec, uint8 expansion, time_t mute_time, LocaleConstant locale, uint32 recruiter, bool isARecruiter);
         ~WorldSession();
 
         bool PlayerLoading() const { return !m_playerLoading.IsEmpty(); }

src/server/game/Server/WorldSocket.cpp

@@ -729,7 +729,7 @@ void WorldSocket::HandleAuthSessionCallback(std::shared_ptr<WorldPackets::Auth::
     sScriptMgr->OnAccountLogin(account.Id);
 
     _authed = true;
-    _worldSession = new WorldSession(account.Id, std::move(authSession->Account), account.Id, shared_from_this(), account.Security,
+    _worldSession = new WorldSession(account.Id, std::move(authSession->Account), shared_from_this(), account.Security,
         account.Expansion, mutetime, account.Locale, account.Recruiter, account.IsRecruiter);
     _worldSession->ReadAddonsInfo(authSession->AddonInfo);
 

src/server/game/Skills/Archaeology/ArchaeologySites.cpp

@@ -46,14 +46,12 @@ void Archaeology::LoadSitesFromDB()
     if (!result)
         return;
 
-    uint32 count = 0;
     do {
         Field *fields = result->Fetch();
         uint32 site = fields[0].GetUInt8();
         uint16 type = fields[1].GetUInt16();
         uint8 finds = fields[2].GetUInt8();
         SetSite(site, type, finds);
-        count++;
     } while (result->NextRow());
 }
 
@@ -249,4 +247,3 @@ void Archaeology::RegenerateAllSites()
     for (uint32 i = 0; i < COUNT_CONT; i++)
         RegenerateContinent(Continent(i));
 }
-

src/server/scripts/Commands/cs_npc.cpp

@@ -864,6 +864,10 @@ class npc_commandscript : public CommandScript
             if (target->GetUInt32Value(UNIT_FIELD_FLAGS) & unitFlags[i].Value)
                 handler->PSendSysMessage("%s (0x%X)", unitFlags[i].Name, unitFlags[i].Value);
 
+        for (uint8 i = 0; i < MAX_UNIT_FLAGS2; ++i)
+            if (target->GetUInt32Value(UNIT_FIELD_FLAGS_2) & unitFlags2[i].Value)
+                handler->PSendSysMessage("%s (0x%X)", unitFlags2[i].Name, unitFlags2[i].Value);
+
         handler->PSendSysMessage(LANG_NPCINFO_FLAGS, target->GetUInt32Value(UNIT_FIELD_FLAGS_2), target->GetUInt32Value(UNIT_DYNAMIC_FLAGS), target->GetFaction());
         handler->PSendSysMessage(LANG_COMMAND_RAWPAWNTIMES, defRespawnDelayStr.c_str(), curRespawnDelayStr.c_str());
         handler->PSendSysMessage(LANG_NPCINFO_LOOT,  cInfo->lootid, cInfo->pickpocketLootId, cInfo->SkinLootId);

src/server/scripts/Kalimdor/zone_silithus.cpp

@@ -868,7 +868,6 @@ class npc_anachronos_quest_trigger : public CreatureScript
                 Player* groupMember = nullptr;
 
                 uint8 GroupMemberCount = 0;
-                uint8 DeadMemberCount = 0;
                 uint8 FailedMemberCount = 0;
 
                 Group::MemberSlotList const& members = EventGroup->GetMemberSlots();
@@ -884,9 +883,6 @@ class npc_anachronos_quest_trigger : public CreatureScript
                         ++FailedMemberCount;
                     }
                     ++GroupMemberCount;
-
-                    if (groupMember->isDead())
-                        ++DeadMemberCount;
                 }
 
                 if (GroupMemberCount == FailedMemberCount || !player->IsWithinDistInMap(me, EVENT_AREA_RADIUS))

src/server/scripts/Spells/spell_warrior.cpp

@@ -178,7 +178,7 @@ class spell_warr_charge : public SpellScript
 // 12809 - Concussion Blow
 class spell_warr_concussion_blow : public SpellScript
 {
-    void CalculateDamage(Unit* victim, int32& damage, int32& flatMod, float& pctMod)
+    void CalculateDamage(Unit* /*victim*/, int32& damage, int32& /*flatMod*/, float& /*pctMod*/)
     {
         damage = CalculatePct(GetCaster()->GetTotalAttackPowerValue(BASE_ATTACK), GetSpellInfo()->Effects[EFFECT_2].CalcValue());
     }