Core/Aura: Fix periodic crit chance snapshot for DoTs (#459)

gonzo1247 · web-flow · commit ecd9870ef5ee · 2026-02-03T07:07:50.000+01:00
diff --git a/src/server/game/Spells/Auras/SpellAuras.cpp b/src/server/game/Spells/Auras/SpellAuras.cpp
@@ -508,7 +508,7 @@ float Aura::CalcPeriodicCritChance(Unit const* caster) const
     if (!modOwner || !CanPeriodicTickCrit(modOwner))
         return 0.f;
 
-    float critChance = modOwner->SpellCritChanceDone(GetSpellInfo(), GetSpellInfo()->GetSchoolMask(), GetSpellInfo()->GetAttackType());
+    float critChance = modOwner->SpellCritChanceDone(GetSpellInfo(), GetSpellInfo()->GetSchoolMask(), GetSpellInfo()->GetAttackType(), true);
     return std::max(0.f, critChance);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,7 @@ float Aura::CalcPeriodicCritChance(Unit const* caster) const`
`508`	`508`	`if (!modOwner \|\| !CanPeriodicTickCrit(modOwner))`
`509`	`509`	`return 0.f;`
`510`	`510`
`511`		`- float critChance = modOwner->SpellCritChanceDone(GetSpellInfo(), GetSpellInfo()->GetSchoolMask(), GetSpellInfo()->GetAttackType());`
	`511`	`+ float critChance = modOwner->SpellCritChanceDone(GetSpellInfo(), GetSpellInfo()->GetSchoolMask(), GetSpellInfo()->GetAttackType(), true);`
`512`	`512`	`return std::max(0.f, critChance);`
`513`	`513`	`}`
`514`	`514`