From 6a586b3285956803a7c5881e5696411a3f9131cb Mon Sep 17 00:00:00 2001 From: Sevi Date: Tue, 10 Mar 2026 00:18:17 +0100 Subject: [PATCH 1/3] Core/ObjectGuid: Properly initialize PackedGuid buffer --- src/server/game/Entities/Object/ObjectGuid.cpp | 1 + src/server/game/Entities/Object/ObjectGuid.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/server/game/Entities/Object/ObjectGuid.cpp b/src/server/game/Entities/Object/ObjectGuid.cpp index 847d95264d..9fd900f35a 100644 --- a/src/server/game/Entities/Object/ObjectGuid.cpp +++ b/src/server/game/Entities/Object/ObjectGuid.cpp @@ -86,6 +86,7 @@ ObjectGuid ObjectGuid::MapSpecific(HighGuid type, uint32 entry, LowType counter) void PackedGuid::Set(ObjectGuid guid) { _packedSize = 1; + _packedGuid.fill(0); uint64 raw = guid.GetRawValue(); for (uint8 i = 0; i < 8; ++i) { diff --git a/src/server/game/Entities/Object/ObjectGuid.h b/src/server/game/Entities/Object/ObjectGuid.h index 81a4ebae0f..84926a4c5a 100644 --- a/src/server/game/Entities/Object/ObjectGuid.h +++ b/src/server/game/Entities/Object/ObjectGuid.h @@ -300,7 +300,7 @@ class TC_GAME_API PackedGuid public: explicit PackedGuid() : _packedSize(1), _packedGuid() { } - explicit PackedGuid(ObjectGuid guid) { Set(guid); } + explicit PackedGuid(ObjectGuid guid) : _packedSize(1), _packedGuid() { Set(guid); } void Set(ObjectGuid guid); From 5e8006908c73ef64cbb5e836bde75a5da19ce62e Mon Sep 17 00:00:00 2001 From: Ovahlord <18347559+Ovahlord@users.noreply.github.com> Date: Tue, 10 Mar 2026 09:27:44 +0100 Subject: [PATCH 2/3] use correct initializer for buffer initialization --- src/server/game/Entities/Object/ObjectGuid.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/game/Entities/Object/ObjectGuid.cpp b/src/server/game/Entities/Object/ObjectGuid.cpp index 9fd900f35a..74505813bd 100644 --- a/src/server/game/Entities/Object/ObjectGuid.cpp +++ b/src/server/game/Entities/Object/ObjectGuid.cpp @@ -86,7 +86,7 @@ ObjectGuid ObjectGuid::MapSpecific(HighGuid type, uint32 entry, LowType counter) void PackedGuid::Set(ObjectGuid guid) { _packedSize = 1; - _packedGuid.fill(0); + _packedGuid = { }; uint64 raw = guid.GetRawValue(); for (uint8 i = 0; i < 8; ++i) { From 60529b07bcd47b8139b3b35814470cf18de3c781 Mon Sep 17 00:00:00 2001 From: Ovahlord <18347559+Ovahlord@users.noreply.github.com> Date: Tue, 10 Mar 2026 09:30:48 +0100 Subject: [PATCH 3/3] correct array initialization in PackedGuid constructors --- src/server/game/Entities/Object/ObjectGuid.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/game/Entities/Object/ObjectGuid.h b/src/server/game/Entities/Object/ObjectGuid.h index 84926a4c5a..a064edae1f 100644 --- a/src/server/game/Entities/Object/ObjectGuid.h +++ b/src/server/game/Entities/Object/ObjectGuid.h @@ -299,8 +299,8 @@ class TC_GAME_API PackedGuid friend TC_GAME_API ByteBuffer& operator<<(ByteBuffer& buf, PackedGuid const& guid); public: - explicit PackedGuid() : _packedSize(1), _packedGuid() { } - explicit PackedGuid(ObjectGuid guid) : _packedSize(1), _packedGuid() { Set(guid); } + explicit PackedGuid() : _packedSize(1), _packedGuid({}) { } + explicit PackedGuid(ObjectGuid guid) : _packedSize(1), _packedGuid({}) { Set(guid); } void Set(ObjectGuid guid);