Skip to content

Properly initialize PackedGuid buffer #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovahlord merged 3 commits into from
Mar 10, 2026
Merged

Properly initialize PackedGuid buffer #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a586b3
Core/ObjectGuid: Properly initialize PackedGuid buffer
gonzo1247 Mar 9, 2026
5e80069
use correct initializer for buffer initialization
Ovahlord Mar 10, 2026
60529b0
correct array initialization in PackedGuid constructors
Ovahlord Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/server/game/Entities/Object/ObjectGuid.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ ObjectGuid ObjectGuid::MapSpecific(HighGuid type, uint32 entry, LowType counter)
void PackedGuid::Set(ObjectGuid guid)
{
_packedSize = 1;
_packedGuid = { };
uint64 raw = guid.GetRawValue();
for (uint8 i = 0; i < 8; ++i)
{
Expand Down
4 changes: 2 additions & 2 deletions src/server/game/Entities/Object/ObjectGuid.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ class TC_GAME_API PackedGuid
friend TC_GAME_API ByteBuffer& operator<<(ByteBuffer& buf, PackedGuid const& guid);

public:
explicit PackedGuid() : _packedSize(1), _packedGuid() { }
explicit PackedGuid(ObjectGuid guid) { Set(guid); }
explicit PackedGuid() : _packedSize(1), _packedGuid({}) { }
explicit PackedGuid(ObjectGuid guid) : _packedSize(1), _packedGuid({}) { Set(guid); }

void Set(ObjectGuid guid);

Expand Down