Packets/Party: fix GUID byte handling in role packets#468
Open
gonzo1247 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Fix corrupted GUID handling in CMSG_SET_ROLE and SMSG_ROLE_CHANGED_INFORM.
During the packet class conversion, one GUID byte was read/written twice while another byte was skipped:
As a result, role selection responses could resolve to an invalid group member GUID, causing role updates to fail.
This restores the GUID byte order used by the previous raw packet handlers.
Tests performed: (Does it build, tested in-game, etc)
build
Tested ingame:
**
This regression was introduced by commit 056248c
("Core/Packets: converted CMSG_SET_ROLE and SMSG_ROLE_CHANGED_INFORM to packet class").
During the packet class conversion, one ChangedUnit GUID byte was duplicated while another one was skipped:
This causes CMSG_SET_ROLE to decode a corrupted ChangedUnit GUID, so Group::SetLfgRoles cannot resolve the selected group member and the selected role is not applied.