fix(agents): add default None values to RetrieverTools class attributes#306
Merged
luarss merged 1 commit intoJun 20, 2026
Conversation
Bare type annotations without default values do not create class attributes in Python — they only populate __annotations__. This caused hasattr(RetrieverTools, "install_retriever") to return False, breaking TestRetrieverTools.test_class_attributes_structure. Signed-off-by: Jack Luar <jluar@precisioninno.com>
luarss
force-pushed
the
fix/retriever-tools-class-attributes
branch
from
9ea639a to
5ef776a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_retriever: Optional[...]) do not create class attributes in Python — they only populate__annotations__hasattr(RetrieverTools, "install_retriever")to returnFalse, breakingTestRetrieverTools.test_class_attributes_structurein CI= Nonedefaults to all six retriever class attributes to match the existingNone-check guards already present in the codeTest plan
pytest tests/test_retriever_tools.py::TestRetrieverTools::test_class_attributes_structurepasses