fix(generate_klayout_tech): remove unused reference_dir / use_relative_paths

Per maliberty's review on #4234: rather than keep `reference_dir` and
`use_relative_paths` around as ignored backward-compat parameters,
drop them entirely and update flow/Makefile to stop passing
`--reference-dir`.  No remaining caller in the tree relies on either.

Changes:
  * flow/util/generate_klayout_tech.py — `generate_klayout_tech()`
    signature is now (template_lyt, output_lyt, lef_files,
    map_files=None).  CLI loses `--reference-dir` and
    `--use-relative-paths`.  Stale comment / docstring lines about
    the dropped args go too.
  * flow/Makefile — `do-klayout` and `do-klayout_wrap` both stop
    passing `--reference-dir`.
  * flow/test/test_generate_klayout_tech.py — drops the now-invalid
    `reference_dir=` / `use_relative_paths=` kwargs from the three
    integration-style tests.  Existing 13 tests still pass.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

Author: oharboe

flow/Makefile

@@ -200,7 +200,6 @@ do-klayout:
 		--template $(KLAYOUT_TECH_FILE) \
 		--output $(OBJECTS_DIR)/klayout.lyt \
 		--lef-files $(OBJECTS_DIR)/klayout_tech.lef $(SC_LEF) $(ADDITIONAL_LEFS) \
-		--reference-dir $(RESULTS_DIR) \
 		--map-files $(wildcard $(FLOW_HOME)/platforms/$(PLATFORM)/*map)
 
 $(OBJECTS_DIR)/klayout_wrap.lyt: $(KLAYOUT_TECH_FILE) $(OBJECTS_DIR)/klayout_tech.lef
@@ -212,8 +211,7 @@ do-klayout_wrap:
 	$(PYTHON_EXE) $(UTILS_DIR)/generate_klayout_tech.py \
 		--template $(KLAYOUT_TECH_FILE) \
 		--output $(OBJECTS_DIR)/klayout_wrap.lyt \
-		--lef-files $(OBJECTS_DIR)/klayout_tech.lef $(WRAP_LEFS) \
-		--reference-dir $(OBJECTS_DIR)/def
+		--lef-files $(OBJECTS_DIR)/klayout_tech.lef $(WRAP_LEFS)
 
 $(WRAPPED_LEFS):
 	mkdir -p $(OBJECTS_DIR)/lef $(OBJECTS_DIR)/def

flow/test/test_generate_klayout_tech.py

@@ -120,9 +120,7 @@ def test_basic_generation(self):
             template_lyt=self.template,
             output_lyt=self.output,
             lef_files=[lef_path],
-            reference_dir=self.results_dir,
             map_files=[],
-            use_relative_paths=True,
         )
 
         with open(self.output) as f:
@@ -152,9 +150,7 @@ def test_with_map_files(self):
             template_lyt=self.template,
             output_lyt=self.output,
             lef_files=[lef_path],
-            reference_dir=self.results_dir,
             map_files=[map_path],
-            use_relative_paths=False,
         )
 
         with open(self.output) as f:
@@ -181,9 +177,7 @@ def test_multiple_lef_files(self):
             template_lyt=self.template,
             output_lyt=self.output,
             lef_files=lef_files,
-            reference_dir=self.results_dir,
             map_files=[],
-            use_relative_paths=True,
         )
 
         with open(self.output) as f:

flow/util/generate_klayout_tech.py

@@ -30,27 +30,14 @@ def replace_map_files(content, map_files):
     return content
 
 
-def generate_klayout_tech(
-    template_lyt,
-    output_lyt,
-    lef_files,
-    reference_dir=None,
-    map_files=None,
-    use_relative_paths=False,
-):
+def generate_klayout_tech(template_lyt, output_lyt, lef_files, map_files=None):
     """Generate a klayout .lyt file from a platform template.
 
     Args:
         template_lyt: Path to the platform .lyt template file.
         output_lyt: Path to write the generated .lyt file.
         lef_files: List of LEF file paths to include.
-        reference_dir: Unused. Accepted for backward compatibility with
-            callers (e.g. flow/Makefile) that still pass it from when
-            paths were resolved relative to this directory.
         map_files: List of map file paths.
-        use_relative_paths: Unused. Same backward-compat rationale as
-            reference_dir -- paths are always written as plain abspath
-            now, regardless of this flag.
     """
     with open(template_lyt, "r") as f:
         content = f.read()
@@ -63,8 +50,7 @@ def generate_klayout_tech(
     # action execution -- they're only at the per-action sandbox -- so
     # resolution fails with errno=2.  Plain abspath (NOT realpath, which
     # would chase Bazel input-file symlinks back out to the bare execroot)
-    # keeps klayout pointed at the in-sandbox file.  reference_dir and
-    # use_relative_paths are both ignored.
+    # keeps klayout pointed at the in-sandbox file.
     resolved_lefs = [os.path.abspath(f) for f in lef_files]
 
     content = replace_lef_files(content, resolved_lefs)
@@ -87,35 +73,16 @@ def main():
     parser.add_argument(
         "--lef-files", nargs="*", default=[], help="LEF files to include"
     )
-    parser.add_argument(
-        "--reference-dir",
-        required=False,
-        default=None,
-        help=(
-            "Unused; accepted for backward compatibility. LEF / map paths "
-            "are written as plain abspath regardless of this directory."
-        ),
-    )
     parser.add_argument(
         "--map-files", nargs="*", default=[], help="Map files to include"
     )
-    parser.add_argument(
-        "--use-relative-paths",
-        action="store_true",
-        help=(
-            "Unused; accepted for backward compatibility. LEF / map paths "
-            "are written as plain abspath regardless of this flag."
-        ),
-    )
     args = parser.parse_args()
 
     generate_klayout_tech(
         template_lyt=args.template,
         output_lyt=args.output,
         lef_files=args.lef_files,
-        reference_dir=args.reference_dir,
         map_files=args.map_files,
-        use_relative_paths=args.use_relative_paths,
     )