Skip to content

Commit caf59b6

Browse files
committed
flow: fix typo in dragons comment references
Correct `export := $(VAR)` to `export VAR := $(VAR)` in comments near OPENROAD_EXE and YOSYS_EXE so they match the actual anti-pattern called out in the dragons warning near PYTHON_EXE. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
1 parent 9f5a086 commit caf59b6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

flow/scripts/variables.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ else
102102
OPENSTA_EXE ?= $(abspath $(FLOW_HOME)/../tools/install/OpenROAD/bin/sta)
103103
endif
104104

105-
# See dragons comment near PYTHON_EXE: bare `export`, not `export := $(VAR)`.
105+
# See dragons comment near PYTHON_EXE: bare `export`, not `export VAR := $(VAR)`.
106106
export OPENROAD_EXE
107107
export OPENSTA_EXE
108108

@@ -119,7 +119,7 @@ else
119119
YOSYS_EXE ?= $(abspath $(FLOW_HOME)/../tools/install/yosys/bin/yosys)
120120
endif
121121

122-
# See dragons comment near PYTHON_EXE: bare `export`, not `export := $(VAR)`.
122+
# See dragons comment near PYTHON_EXE: bare `export`, not `export VAR := $(VAR)`.
123123
export YOSYS_EXE
124124

125125
YOSYS_IS_VALID := $(if $(YOSYS_EXE),$(shell test -x $(YOSYS_EXE) && echo "true"),)

0 commit comments

Comments
 (0)