bazel: enable blender 3D-viewer targets on every supported-PDK design

Flip `blender = True` once, globally, in flow/designs/design.bzl's
design() wrapper.  Every design routes through this single funnel,
so this is the only ORFS-side line that changes.

Two small bazel-orfs patches make the global flip safe:

  0002-blender.bzl-export-blender_supports_pdk-predicate.patch
    Exposes `blender_supports_pdk(pdk)`.  Lets callers ask "does this
    PDK have a BlenderGDS stackup?" without provoking the loud
    fail() in _pdk_to_blendergds (which we keep — it's a useful guard
    for anyone calling orfs_blender() directly with a bogus PDK).

  0003-orfs_design.bzl-forward-blender-silently-skip-unsupp.patch
    Adds a `blender = False` parameter to orfs_design() and forwards
    it to orfs_flow().  When True but the design's PDK is unsupported
    (asap7, nangate45, …) the request silently downgrades to False,
    so no `_blender*` targets are declared and @blender / @blendergds
    are never referenced by analysis.

Confirmed behaviour after these patches:

  * `bazelisk query //flow/designs/sky130hd/gcd:all` shows the 5
    `gcd_final_blender*` targets (sky130hd is supported).
  * `bazelisk query //flow/designs/asap7/gcd:all` shows none of them
    (asap7 has no BlenderGDS stackup — silent skip).
  * `bazelisk query 'tests(//flow/designs/sky130hd/gcd:all)'` returns
    only `gcd_test` — `tags = ["manual"]` keeps the blender targets
    out of `bazelisk test //...` wildcards.

`bazelisk build //flow/designs/sky130hd/gcd:gcd_final_blender_html`
runs the full physical-design flow to completion and then fails at
the orfs_gds klayout-merge step (klayout looks up klayout_tech.lef
under the non-sandbox execroot rather than the active processwrapper
sandbox).  That failure is in bazel-orfs's orfs_gds rule and surfaces
because orfs_blender exercises orfs_gds with the host PATH klayout
for the first time on this design; it is independent of these
patches and will be triaged separately.

bazel-orfs patches are vendored under patches/bazel-orfs/ via the
existing git_override(patches=…) mechanism.  Upstreaming is
deferred until the orfs_gds klayout-merge issue is sorted out, to
minimise bazel-orfs churn.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

Author: oharboe

MODULE.bazel

@@ -49,11 +49,13 @@ BAZEL_ORFS_REMOTE = "https://github.com/The-OpenROAD-Project/bazel-orfs.git"
 git_override(
     module_name = "bazel-orfs",
     commit = BAZEL_ORFS_COMMIT,
-    remote = BAZEL_ORFS_REMOTE,
     patch_strip = 1,
     patches = [
         "//patches/bazel-orfs:0001-flow.bzl-pull-synth-into-generate_metadata-data-deps.patch",
+        "//patches/bazel-orfs:0002-blender.bzl-export-blender_supports_pdk-predicate.patch",
+        "//patches/bazel-orfs:0003-orfs_design.bzl-forward-blender-silently-skip-unsupp.patch",
     ],
+    remote = BAZEL_ORFS_REMOTE,
 )
 
 git_override(

flow/designs/design.bzl

@@ -74,6 +74,7 @@ def design(config = "config.mk", user_arguments = [], user_sources = [], local_a
         user_arguments = user_arguments,
         user_sources = user_sources,
         local_arguments = local_arguments,
+        blender = True,
     )
 
 def files(group, extra_srcs = None):

patches/bazel-orfs/0002-blender.bzl-export-blender_supports_pdk-predicate.patch

@@ -0,0 +1,45 @@
+From 151270e17f51ab260bf0e9ad8479ccf009b02c5f Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=98yvind=20Harboe?= <oyvind@ascenium.com>
+Date: Sat, 16 May 2026 14:35:12 +0200
+Subject: [PATCH 2/3] blender.bzl: export blender_supports_pdk predicate
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Lets higher-level macros decide whether to request blender = True from
+orfs_flow without provoking the loud fail() in _pdk_to_blendergds.
+
+The next commit teaches orfs_design() to silently downgrade
+blender = True to False when the design's PDK has no BlenderGDS
+stackup, so a single project-wide `blender = True` flip in
+flow/designs/design.bzl on the ORFS side works across all PDKs.
+
+Signed-off-by: Øyvind Harboe <oyvind@ascenium.com>
+---
+ private/blender.bzl | 10 ++++++++++
+ 1 file changed, 10 insertions(+)
+
+diff --git a/private/blender.bzl b/private/blender.bzl
+index 444c65c..bcafae6 100644
+--- a/private/blender.bzl
++++ b/private/blender.bzl
+@@ -52,6 +52,16 @@ def _pdk_to_blendergds(pdk):
+         )
+     return _PDK_TO_BLENDERGDS[short]
+ 
++def blender_supports_pdk(pdk):
++    """True iff orfs_blender() will accept this PDK label.
++
++    Lets higher-level macros (e.g. orfs_design) decide whether to request
++    `blender = True` from orfs_flow without provoking the loud fail() in
++    _pdk_to_blendergds. Accepts either a bare short name (`"sky130hd"`)
++    or a label (`"//flow:sky130hd"`).
++    """
++    return _pdk_short_name(pdk) in _PDK_TO_BLENDERGDS
++
+ def _find_addon_root(addon_files):
+     """Locate the BlenderGDS addon root via the dir of __init__.py."""
+     for f in addon_files:
+-- 
+2.51.0
+

patches/bazel-orfs/0003-orfs_design.bzl-forward-blender-silently-skip-unsupp.patch

@@ -0,0 +1,70 @@
+From cc811f203317da88f41bf6fcf19172e67b8ac797 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=98yvind=20Harboe?= <oyvind@ascenium.com>
+Date: Sat, 16 May 2026 14:35:45 +0200
+Subject: [PATCH 3/3] orfs_design.bzl: forward blender, silently skip
+ unsupported PDKs
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Add a pass-through `blender =` parameter to orfs_design().  When True,
+forward to orfs_flow() — but only if the design's PDK has a BlenderGDS
+stackup (per blender_supports_pdk).  On unsupported PDKs the request
+silently downgrades to False so no blender targets are declared and
+@blender / @blendergds are never referenced by analysis.
+
+Lets the ORFS-side design() wrapper turn on blender = True once,
+globally, without having to enumerate the supported PDK set itself.
+
+Signed-off-by: Øyvind Harboe <oyvind@ascenium.com>
+---
+ private/orfs_design.bzl | 12 +++++++++++-
+ 1 file changed, 11 insertions(+), 1 deletion(-)
+
+diff --git a/private/orfs_design.bzl b/private/orfs_design.bzl
+index d53d4bd..c663be0 100644
+--- a/private/orfs_design.bzl
++++ b/private/orfs_design.bzl
+@@ -10,6 +10,10 @@ The orfs_designs repository rule (designs.bzl) must be instantiated
+ first to parse all config.mk files and generate the DESIGNS dict.
+ """
+ 
++load(
++    "//private:blender.bzl",
++    "blender_supports_pdk",
++)
+ load(
+     "//private:flow.bzl",
+     "orfs_flow",
+@@ -47,7 +51,7 @@ def _convert_sources(sources, pkg):
+             result[var] = converted
+     return result
+ 
+-def orfs_design(name = None, config = "config.mk", platform = None, design = None, designs = None, mock_openroad = None, mock_yosys = None, user_arguments = [], user_sources = [], local_arguments = []):  # buildifier: disable=unused-variable
++def orfs_design(name = None, config = "config.mk", platform = None, design = None, designs = None, mock_openroad = None, mock_yosys = None, user_arguments = [], user_sources = [], local_arguments = [], blender = False):  # buildifier: disable=unused-variable
+     """Create orfs_flow() targets for a design based on its parsed config.mk.
+ 
+     Usage:
+@@ -92,6 +96,11 @@ def orfs_design(name = None, config = "config.mk", platform = None, design = Non
+             which appears verbatim inside VERILOG_FILES). These are
+             dropped entirely before orfs_flow() is invoked — neither
+             validated against variables.yaml nor exposed as env vars.
++        blender: if True, request the orfs_flow blender 3D-viewer targets
++            for this design. Silently downgraded to False on PDKs that
++            have no BlenderGDS stackup (see blender_supports_pdk in
++            private/blender.bzl), so callers can flip this on globally
++            without having to enumerate supported PDKs.
+     """
+     if designs == None:
+         fail("orfs_design() requires designs: load orfs_design from @orfs_designs//:designs.bzl")
+@@ -233,6 +242,7 @@ def orfs_design(name = None, config = "config.mk", platform = None, design = Non
+         macros = macros if macros else [],
+         stage_data = {"synth": extra_data} if extra_data else {},
+         tags = tags,
++        blender = blender and blender_supports_pdk("//flow:" + platform),
+     )
+ 
+     # Lint flow — fast validation with mock-openroad (only if configured)
+-- 
+2.51.0
+