Skip to content

util: remove unused pandas dependency#3212

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
Pinata-Consulting:ci-reduce-dependencies
Jun 14, 2025
Merged

util: remove unused pandas dependency#3212
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
Pinata-Consulting:ci-reduce-dependencies

Conversation

@oharboe

@oharboe oharboe commented Jun 6, 2025

Copy link
Copy Markdown
Collaborator

Helpful in CI where minimal python installations are used, no need to add pandas

Helpful in CI where minimal python installations are used, no need
to add pandas

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe oharboe requested a review from maliberty June 6, 2025 11:04
@maliberty

Copy link
Copy Markdown
Member

@vvbandeira any concerns?

@maliberty maliberty requested a review from vvbandeira June 6, 2025 17:49
@oharboe

oharboe commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator Author

@vvbandeira @maliberty OK?

@vvbandeira

Copy link
Copy Markdown
Member

I am trying to remember where this was used, DARPA reports, Dashboard or AT.
@sombraSoft, can you confirm that this is not used for the dashboard?
@luarss, can you confirm that this is not used for AutoTuner?

@luarss

luarss commented Jun 14, 2025

Copy link
Copy Markdown
Contributor

@vvbandeira Its not being used anywhere in the codebase (keyword search: extract_metrics, metrics_dict, metrics_df)

@oharboe

oharboe commented Jun 14, 2025

Copy link
Copy Markdown
Collaborator Author

@maliberty @vvbandeira merge?

@maliberty

Copy link
Copy Markdown
Member

Just waiting for @sombraSoft to confirm about the dashboard

@sombraSoft

Copy link
Copy Markdown
Contributor

Yes, it can be deleted.

@maliberty maliberty merged commit 997e74a into The-OpenROAD-Project:master Jun 14, 2025
7 checks passed
@oharboe oharboe deleted the ci-reduce-dependencies branch June 26, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants