variables: syntax error check in env_var_equals#3378
Closed
oharboe wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
This is verifying that a variable used in env_var_equals has been documented in variables.yaml? Sounds reasonable. Would you want to extend this to env_var_exists_and_non_empty in case someone fat fingers the env var there?. It looks like it would cover append_env_var and env_var_or_empty as well. |
Collaborator
Author
|
Yes, that was the idea. I'm not going to pick up this work now, but I though it would be nice to have in place and save us some more agony. Feel free cherry pick this & continue if you find it useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeffng-or Thoughts?