Add global variables for repair antennas iterations#3403
Conversation
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
…ate/OpenROAD-flow-scripts into add_variables_repair_antennas_iter
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
Please note the merge conflict |
…ate/OpenROAD-flow-scripts into add_variables_repair_antennas_iter
|
I'm confused why we introduced MAX_REPAIR_ANTENNAS_ITER_GRT. It has no documentation and it appears we won't do any antenna repair if it is not set. Also there is @jeffng-or 's problem |
@maliberty We first added both MAX_REPAIR_ANTENNAS_ITER_GRT and MAX_REPAIR_ANTENNAS_ITER_DRT because one design had 1 antenna violation at the end of the 5 iterations, but running a new iteration fixed it. So the idea was to allow design-specific configuration regarding how many iteration it will run to remove the violations. The missing documentation is my fault. If you believe it's worth to keep these options, I can update the docs. What problem Jeff is facing related to this PR? I didn't find an specific issue mentioning repair_antennas. |
|
There should be a default for the variable of 5 rather than embedding it into each platform. |
Ok, I'll do the fixes now. |
|
Why not continue running iterations until the number of violations no longer decreases? And the user can set an iteration cap if they want. |
Creating global variables for the maximum number of repair antenna iterations in GRT and DRT.
designs/sky130hs/jpeg/rules-base.json updates: