Skip to content

Add global variables for repair antennas iterations#3403

Merged
eder-matheus merged 10 commits into
The-OpenROAD-Project:masterfrom
luis201420:add_variables_repair_antennas_iter
Aug 15, 2025
Merged

Add global variables for repair antennas iterations#3403
eder-matheus merged 10 commits into
The-OpenROAD-Project:masterfrom
luis201420:add_variables_repair_antennas_iter

Conversation

@luis201420

@luis201420 luis201420 commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

Creating global variables for the maximum number of repair antenna iterations in GRT and DRT.

designs/sky130hs/jpeg/rules-base.json updates:

Metric Old New Type
globalroute__antenna_diodes_count 87 141 Failing
detailedroute__antenna__violating__nets 1 0 Tighten
detailedroute__antenna_diodes_count 86 154 Failing

Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
@eder-matheus eder-matheus enabled auto-merge August 14, 2025 23:36
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
@maliberty

Copy link
Copy Markdown
Member

Please note the merge conflict

@eder-matheus eder-matheus merged commit f887692 into The-OpenROAD-Project:master Aug 15, 2025
8 checks passed
@maliberty

Copy link
Copy Markdown
Member

I'm confused why we introduced MAX_REPAIR_ANTENNAS_ITER_GRT. It has no documentation and it appears we won't do any antenna repair if it is not set. Also there is @jeffng-or 's problem

@eder-matheus

Copy link
Copy Markdown
Member

I'm confused why we introduced MAX_REPAIR_ANTENNAS_ITER_GRT. It has no documentation and it appears we won't do any antenna repair if it is not set. Also there is @jeffng-or 's problem

@maliberty We first added both MAX_REPAIR_ANTENNAS_ITER_GRT and MAX_REPAIR_ANTENNAS_ITER_DRT because one design had 1 antenna violation at the end of the 5 iterations, but running a new iteration fixed it. So the idea was to allow design-specific configuration regarding how many iteration it will run to remove the violations.

The missing documentation is my fault. If you believe it's worth to keep these options, I can update the docs.

What problem Jeff is facing related to this PR? I didn't find an specific issue mentioning repair_antennas.

@maliberty

Copy link
Copy Markdown
Member

See f887692#r164081818

There should be a default for the variable of 5 rather than embedding it into each platform.

@eder-matheus

Copy link
Copy Markdown
Member

See f887692#r164081818

There should be a default for the variable of 5 rather than embedding it into each platform.

Ok, I'll do the fixes now.

@rovinski

Copy link
Copy Markdown
Collaborator

Why not continue running iterations until the number of violations no longer decreases? And the user can set an iteration cap if they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants