make: check if binaries are valid before continuing#3430
Merged
maliberty merged 1 commit intoAug 26, 2025
Merged
Conversation
The current logic in variables.mk results in OPENROAD_EXE and YOSYS_EXE to always be set to something, either the absolute path to tools/install or the value from the parent env. With this behavior, when calling make versions.txt the if statements are always true and the "not available" is never printed to the versions.txt file. If the bins are not valid it just prints an empty string. Before this change, calling make versions.txt would fail silently ($? == 0) and other make commands would fail when trying to run openroad or yosys. After this change, calling any make command without having a valid openroad or yosys binary will fail with an error message, which is the same behaviour already implemented for klayout. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
maliberty
approved these changes
Aug 26, 2025
Collaborator
|
@maliberty @vvbandeira @povik This breaks bazel-orfs because OPENROAD_EXE is not a dependency for Yosys canonicalization, the ranslation of Verilog & SystemVerilog to .rtilil step: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic in variables.mk results in OPENROAD_EXE and YOSYS_EXE to always be set to something, either the absolute path to tools/install or the value from the parent env. With this behavior, when calling make versions.txt the if statements are always true and the "not available" is never printed to the versions.txt file. If the bins are not valid, it just prints an empty string.
Before this change, calling make versions.txt would fail silently ($? == 0) and other make commands would fail when trying to run openroad or yosys.
After this change, calling any make command without having a valid openroad or yosys binary will fail with an error message, which is the same behaviour already implemented for klayout.