allow macro preplacement and make ngt45/bp our first test case with partial mpl#3472
Merged
maliberty merged 6 commits intoSep 10, 2025
Merged
Conversation
file exists Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
AcKoucher
force-pushed
the
preplaced-macros
branch
from
c10d423 to
b28c3fe
Compare
AcKoucher
changed the title
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
AcKoucher
force-pushed
the
preplaced-macros
branch
from
b28c3fe to
09e0018
Compare
AcKoucher
changed the title
maliberty
reviewed
Sep 8, 2025
Contributor
Author
|
If the changes here are ok I can update the OR submodule before we merge it so that the CI doesn't break. |
Member
|
go ahead and update |
Merged
when there are preplaced macros Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
AcKoucher
changed the title
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
maliberty
approved these changes
Sep 9, 2025
maliberty
reviewed
Sep 10, 2025
Co-authored-by: Matt Liberty <matt.liberty@gmail.com> Signed-off-by: Arthur Koucher <104802710+AcKoucher@users.noreply.github.com>
maliberty
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #8099 and #3481
Modify scripts in order to allow macro pre-placement and make ngt45/bp our first test case for both fixed and unfixed macros.