fix: ensure exit() is called for invalid units in correlateRC.py#4055
Merged
eder-matheus merged 1 commit intoMar 25, 2026
Merged
Conversation
exit without parentheses is a no-op in Python; replace with exit(1) so invalid res_unit/cap_unit arguments terminate the script immediately instead of continuing with undefined res_scale/cap_scale variables. Signed-off-by: Ashnaa Seth <ashnaaseth2325@gmail.com> Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
ashnaaseth2325-oss
force-pushed
the
fix/correlateRC-exit-noop
branch
from
101c338 to
0b68105
Compare
Contributor
Author
|
Hi @eder-matheus @maliberty, |
eder-matheus
approved these changes
Mar 25, 2026
Contributor
Author
|
@eder-matheus |
Member
The Jenkins pipelines didn't finished yet. I'll merge once it finishes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a small bug in
correlateRC.pywhereexitwasn’t actually being called. The script now stops immediately on invalid units instead of crashing later.FIX
Before
After
VERIFICATION
Run with an invalid unit:
Now: prints error and exits
Before: continued →
NameError