fix: require --logs, --reports, and --results to prevent NoneType crash in genMetrics#4065
Merged
maliberty merged 1 commit intoMar 28, 2026
Conversation
Signed-off-by: Ashnaa Seth <ashnaaseth2325@gmail.com> Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Contributor
Author
|
Hi @maliberty @eder-matheus, |
maliberty
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. SUMMARY
This PR makes
--logs,--reports, and--resultsrequired CLI arguments ingenMetrics.pyto prevent runtime crashes caused by missing values.The change is localized to argument parsing in
flow/util/genMetrics.pyand improves error handling without altering core logic.2. FIX
3. VERIFICATION
Ran the script without
--logs,--reports, and--resultsto reproduce the issue—previously it crashed with a confusingTypeError. After the fix, it now fails immediately with a clear argparse message indicating the missing required arguments. When all three flags are provided, the script runs normally without errors.