fix: use context managers to prevent file descriptor leaks in genMetrics.py#4066
Merged
maliberty merged 3 commits intoMar 30, 2026
Conversation
Replace bare open()/close() calls in read_sdc() and merge_jsons() with context managers so file descriptors are released on exception. Signed-off-by: Ashnaa Seth <ashnaaseth2325@gmail.com> Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Contributor
Author
|
Hi @maliberty @eder-matheus, |
maliberty
reviewed
Mar 28, 2026
Co-authored-by: Matt Liberty <matt.liberty@gmail.com> Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Signed-off-by: Ashnaa Seth <ashnaaseth2325@gmail.com>
ashnaaseth2325-oss
force-pushed
the
fix/genmetrics-fd-leaks
branch
from
79a4ae6 to
9f313aa
Compare
Contributor
Author
|
Hi @maliberty, thanks for the review! |
Contributor
Author
|
Hello @maliberty @eder-matheus |
maliberty
approved these changes
Mar 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes file descriptor leaks in
flow/util/genMetrics.pyby replacing manual file handling with context managers. The changes primarily affect theread_sdc()andmerge_jsons()functions, ensuring files are always properly closed even when exceptions occur.FIX
VERIFICATION
Run a normal OpenROAD flow to make sure everything works as before with valid inputs. Then try breaking a metrics JSON file (e.g., truncate it) and rerun the flow. It should handle the error cleanly without leaking file descriptors or crashing.