Skip to content

fix: use context managers to prevent file descriptor leaks in genMetrics.py #4066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 3 commits into from
Mar 30, 2026
Merged

fix: use context managers to prevent file descriptor leaks in genMetrics.py #4066

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b03fa0
util: use context managers in genMetrics.py to fix fd leaks
ashnaaseth2325-oss Mar 28, 2026
75af8d6
Update flow/util/genMetrics.py
ashnaaseth2325-oss Mar 28, 2026
9f313aa
fix: correct f-string syntax
ashnaaseth2325-oss Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions flow/util/genMetrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,17 +142,14 @@ def extractGnuTime(prefix, jsonFile, file):
#
def read_sdc(file_name):
clkList = []
sdcFile = None

try:
sdcFile = open(file_name, "r")
except IOError:
print("[WARN] Failed to open file:", file_name)
with open(file_name, "r") as sdcFile:
lines = sdcFile.readlines()
except OSError as e:
print(f"[WARN] Failed to open file: {file_name} ({e})")
return clkList

lines = sdcFile.readlines()
sdcFile.close()

for line in lines:
if len(line.split()) < 2:
continue
Expand Down Expand Up @@ -185,10 +182,9 @@ def is_git_repo(folder=None):
def merge_jsons(root_path, output, files):
paths = sorted(glob(os.path.join(root_path, files)))
for path in paths:
file = open(path, "r")
data = json.load(file)
with open(path, "r") as file:
data = json.load(file)
output.update(data)
file.close()


def extract_metrics(
Expand Down