Skip to content

fix(addDummyToLef): prevent fd leaks and add input file validation with clear error handling #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eder-matheus merged 1 commit into from
Mar 30, 2026
Merged

fix(addDummyToLef): prevent fd leaks and add input file validation with clear error handling #4067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions flow/util/addDummyToLef.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/usr/bin/env python3
import os
import re
import sys
import argparse # argument parsing
Expand All @@ -14,9 +15,12 @@
args = parser.parse_args()


f = open(args.inputLef)
content = f.read()
f.close()
if not os.path.isfile(args.inputLef):
print(f"Error: Input LEF not found: {args.inputLef}", file=sys.stderr)
sys.exit(1)

with open(args.inputLef) as f:
content = f.read()

# refMacro = "BUFH_X1M_A12TR"

Expand All @@ -26,9 +30,8 @@
result, count = re.subn(pattern, replace, content, 1, re.S)

if count > 0:
f = open(args.outputLef, "w")
f.write(result)
f.close()
with open(args.outputLef, "w") as f:
f.write(result)
else:
print("Error: Pattern not found")
print("Error: Pattern not found", file=sys.stderr)
sys.exit(1)