Skip to content

Clarify detailed-route metrics for antenna repair reroutes #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alokkumardalei-wq wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Clarify detailed-route metrics for antenna repair reroutes #4133

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8606e26
Clarify post-route antenna repair metrics
alokkumardalei-wq Apr 10, 2026
d1068de
ci: retrigger jenkins
alokkumardalei-wq Apr 11, 2026
5883008
Use push/pop metrics stage for antenna repair iterations
alokkumardalei-wq Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions flow/scripts/detail_route.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,22 @@ if {
!$::env(SKIP_ANTENNA_REPAIR_POST_DRT) &&
[env_var_exists_and_non_empty MAX_REPAIR_ANTENNAS_ITER_DRT]
} {
set repair_antennas_iters 1
if { [repair_antennas] } {
detailed_route {*}$all_args
}
set repair_antennas_iters 0
set repair_antennas_count -1
utl::set_metrics_stage "detailedroute__drt__repair_antennas__pre_repair__{}"
while { [check_antennas] && $repair_antennas_iters < $::env(MAX_REPAIR_ANTENNAS_ITER_DRT) } {
repair_antennas
utl::set_metrics_stage "detailedroute__drt__repair_antennas__iter_${repair_antennas_iters}__{}"
set repair_antennas_count [repair_antennas]
detailed_route {*}$all_args
incr repair_antennas_iters
}
utl::set_metrics_stage "detailedroute__{}"

@osamahammad21 osamahammad21 Apr 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of jumping back a stage. Essentially metrics stages are designed as a stack. This should be something like .. detailedroute__post_repair__
My concern is linking some unrelated metrics, like the base wire length reported from the first detailed_route run, and the the number of final diodes. The wire length changed since then, but not updated for the detailedroute__ metric

if { $repair_antennas_count == -1 } {
# Preserve the top-level diode count metric even when no post-DRT repair is needed.
repair_antennas
} else {
utl::metric_int "antenna_diodes_count" $repair_antennas_count
}
} else {
utl::metric_int "antenna_diodes_count" -1
}
Expand Down