adapt macro placer script to use new command set_macro_default_halo and update OR#4149
Closed
AcKoucher wants to merge 1 commit into
Closed
adapt macro placer script to use new command set_macro_default_halo and update OR#4149AcKoucher wants to merge 1 commit into
AcKoucher wants to merge 1 commit into
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the macro_place_util.tcl script to use the set_macro_default_halo command for setting macro halos, replacing the previous method of passing them as arguments to rtlmp. It also updates the tools/OpenROAD subproject to a newer commit. I have no feedback to provide.
4 tasks
AcKoucher
force-pushed
the
adapt-macro-placer-scripts
branch
from
1fa6d8b to
a53c485
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires The-OpenROAD-Project/OpenROAD#10142.