log_cmd improve_placement& optimize_mirroring#4155
Merged
maliberty merged 1 commit intoApr 17, 2026
Conversation
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates flow/scripts/detail_place.tcl to wrap the improve_placement and optimize_mirroring commands with log_cmd for better logging. A review comment suggests refactoring the logic for building improve_placement arguments by using the append_env_var helper to enhance code conciseness and maintain consistency with other parts of the script.
Comment on lines
23
to
27
| if { [env_var_exists_and_non_empty DPO_MAX_DISPLACEMENT] } { | ||
| improve_placement -max_displacement $::env(DPO_MAX_DISPLACEMENT) | ||
| log_cmd improve_placement -max_displacement $::env(DPO_MAX_DISPLACEMENT) | ||
| } else { | ||
| improve_placement | ||
| log_cmd improve_placement | ||
| } |
Contributor
There was a problem hiding this comment.
The logic for building arguments for improve_placement can be simplified using the append_env_var helper. This is more concise and maintains consistency with how other commands (like detailed_placement at line 20) are handled in this script.
set dpo_args {}
append_env_var dpo_args DPO_MAX_DISPLACEMENT -max_displacement 1
log_cmd improve_placement {*}$dpo_args
maliberty
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.