Skip to content

log_cmd improve_placement& optimize_mirroring #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 1 commit into from
Apr 17, 2026
Merged

log_cmd improve_placement& optimize_mirroring #4155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions flow/scripts/detail_place.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ proc do_dpl { } {

if { $::env(ENABLE_DPO) } {
if { [env_var_exists_and_non_empty DPO_MAX_DISPLACEMENT] } {
improve_placement -max_displacement $::env(DPO_MAX_DISPLACEMENT)
log_cmd improve_placement -max_displacement $::env(DPO_MAX_DISPLACEMENT)
} else {
improve_placement
log_cmd improve_placement
}
Comment on lines 23 to 27

@gemini-code-assist gemini-code-assist Bot Apr 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for building arguments for improve_placement can be simplified using the append_env_var helper. This is more concise and maintains consistency with how other commands (like detailed_placement at line 20) are handled in this script.

    set dpo_args {}
    append_env_var dpo_args DPO_MAX_DISPLACEMENT -max_displacement 1
    log_cmd improve_placement {*}$dpo_args

}
optimize_mirroring
log_cmd optimize_mirroring

utl::info FLW 12 "Placement violations [check_placement -verbose]."

Expand Down