-
Notifications
You must be signed in to change notification settings - Fork 513
Fix subcommands #4164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix subcommands #4164
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d2b66c6
fix: strip Bazel runfiles env vars before spawning subprocesses
oharboe c25e22c
flow: preserve OPENROAD_EXE/OPENSTA_EXE origin across sub-makes
oharboe 33fe734
fix: update metric thresholds for multiple designs
oharboe 476d897
bazel: update MODULE.bazel configuration
oharboe 5e5a689
bazel: add BUILD.bazel files for all public-PDK designs
oharboe 2594f8f
docs: add bazel-orfs beta test documentation
oharboe 4b9b01b
bazel: bump bazel-orfs, ORFS image, and openroad versions
oharboe 2b44448
openroad: bump
oharboe ccc7740
bazel: use local tools/OpenROAD instead of git_override
oharboe ee87db9
bazel: include nested .svh headers in mempool_group include filegroups
oharboe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| build --incompatible_strict_action_env | ||
| common --experimental_isolated_extension_usages | ||
| build --cxxopt "-std=c++20" --host_cxxopt "-std=c++20" | ||
| try-import %workspace%/user.bazelrc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit hash
f8b36bf4a92c6e84317a70bab215bdcd2e25a26eis repeated in 7 different places acrossgit_overrideandarchive_overrideblocks (lines 13, 20, 28, 37, 38, 45, 46). This makes version updates highly manual and error-prone. While Bzlmod has limitations regarding variables in overrides, consider if some of these can be consolidated or if a script should be provided to automate the bump.